Sign upLogin

jeresig/pharos-images

View on GitHub
Star
logic/artworks.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function exports has 69 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function(app) {
    const Artwork = models("Artwork");
    const Source = models("Source");

    const cache = require("../server/middlewares/cache");
Severity: Major
Found in logic/artworks.js - About 2 hrs to fix

    Function show has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            show(req, res) {
            const compare = ("compare" in req.query);
            const id = `${req.params.source}/${req.params.artworkName}`;

            Artwork.findById(id, (err, artwork) => {
    Severity: Minor
    Found in logic/artworks.js - About 1 hr to fix

      TODO found
      Open

                          // TODO: Handle error loading images?
      Severity: Minor
      Found in logic/artworks.js by fixme

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

                      if (err || !artwork) {
                    return res.status(404).render("Error", {
                        title: req.gettext("Not found."),
                    });
                }
      Severity: Major
      Found in logic/artworks.js and 3 other locations - About 35 mins to fix
      logic/admin.js on lines 23..27
      logic/admin.js on lines 61..65
      logic/uploads.js on lines 142..146

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status