Sign upLogin

jeresig/pharos-images

View on GitHub
Star
schemas/Artwork.js

Summary

Maintainability
F
4 days
Test Coverage

Function lintData has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring.
Open

    lintData(data, req, optionalSchema) {
        const schema = optionalSchema || Artwork;

        const cleaned = {};
        const warnings = [];
Severity: Minor
Found in schemas/Artwork.js - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File Artwork.js has 425 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"use strict";

const async = require("async");
const validUrl = require("valid-url");
const jdp = require("jsondiffpatch").create({
Severity: Minor
Found in schemas/Artwork.js - About 6 hrs to fix

    Function lintData has 94 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        lintData(data, req, optionalSchema) {
        const schema = optionalSchema || Artwork;

        const cleaned = {};
        const warnings = [];
    Severity: Major
    Found in schemas/Artwork.js - About 3 hrs to fix

      Function fromData has 54 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          fromData(tmpData, req, callback) {
        const Artwork = models("Artwork");
        const Image = models("Image");

        const lint = this.lintData(tmpData, req);
      Severity: Major
      Found in schemas/Artwork.js - About 2 hrs to fix

        Function updateSimilarity has 49 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            updateSimilarity(callback) {
        /* istanbul ignore if */
        if (config.NODE_ENV !== "test") {
            console.log("Updating Similarity", this._id);
        }
        Severity: Minor
        Found in schemas/Artwork.js - About 1 hr to fix

          Function loadImages has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              loadImages(loadSimilarArtworks, callback) {
        async.parallel([
            (callback) => {
                this.getImages((err, images) => {
                    // We filter out any invalid/un-found images
          Severity: Minor
          Found in schemas/Artwork.js - About 1 hr to fix

            Function getExpectedType has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

            const getExpectedType = (options, value) => {
    if (Array.isArray(options.type)) {
        return Array.isArray(value) ? false : "array";
    }
            Severity: Minor
            Found in schemas/Artwork.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid deeply nested control flow statements.
            Open

                                        for (const warning of results.warnings) {
                                warnings.push(
                                    `\`${field}\`: ${warning}`);
                            }
            Severity: Major
            Found in schemas/Artwork.js - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                      if (value.length !== results.length) {
                            warnings.push(options.validationMsg(req));
                        }
              Severity: Major
              Found in schemas/Artwork.js - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                            if (results.error) {
                                warnings.push(
                                    `\`${field}\`: ${results.error}`);
                                return undefined;
                            }
                Severity: Major
                Found in schemas/Artwork.js - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                              if (expectedType) {
                                warnings.push(req.format(req.gettext(
                                    "`%(field)s` value is the wrong type." +
                                        " Expected a %(type)s."),
                                    {field, type: expectedType}));
                  Severity: Major
                  Found in schemas/Artwork.js - About 45 mins to fix

                    Function updateSimilarity has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        updateSimilarity(callback) {
        /* istanbul ignore if */
        if (config.NODE_ENV !== "test") {
            console.log("Updating Similarity", this._id);
        }
                    Severity: Minor
                    Found in schemas/Artwork.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function stripProp has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    const stripProp = (obj, name) => {
    if (!obj) {
        return obj;
    }
                    Severity: Minor
                    Found in schemas/Artwork.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    TODO found
                    Open

                                        // TODO: We should log out some details on when this
                    Severity: Minor
                    Found in schemas/Artwork.js by fixme

                    TODO found
                    Open

                                            // TODO: We should log out some details on when this
                    Severity: Minor
                    Found in schemas/Artwork.js by fixme

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                        similarArtworks: [{
        _id: String,

        artwork: {
            type: String,
                    Severity: Major
                    Found in schemas/Artwork.js and 1 other location - About 3 hrs to fix
                    schemas/Upload.js on lines 47..73

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 101.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        getImages(callback) {
        async.mapLimit(this.images, 4, (id, callback) => {
            if (typeof id !== "string") {
                return process.nextTick(() => callback(null, id));
            }
                    Severity: Major
                    Found in schemas/Artwork.js and 1 other location - About 2 hrs to fix
                    schemas/Upload.js on lines 85..92

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 82.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                    this.getImages((err, images) => {
                    // We filter out any invalid/un-found images
                    // TODO: We should log out some details on when this
                    // happens (hopefully never).
                    this.images = images.filter((image) => !!image);
                    Severity: Minor
                    Found in schemas/Artwork.js and 1 other location - About 30 mins to fix
                    schemas/Artwork.js on lines 262..269

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 45.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                        }, (err, similar) => {
                        // We filter out any invalid/un-found artworks
                        // TODO: We should log out some details on when this
                        // happens (hopefully never).
                        this.similarArtworks =
                    Severity: Minor
                    Found in schemas/Artwork.js and 1 other location - About 30 mins to fix
                    schemas/Artwork.js on lines 231..237

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 45.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status