jeresig/pharos-images

View on GitHub
schemas/ArtworkImport.js

Summary

Maintainability
C
1 day
Test Coverage

Function processArtworks has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    processArtworks(callback) {
        const Artwork = models("Artwork");
        const incomingIDs = {};

        async.eachLimit(this.results, 1, (result, callback) => {
Severity: Minor
Found in schemas/ArtworkImport.js - About 1 hr to fix

    Function importArtworks has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        importArtworks(callback) {
            const Artwork = models("Artwork");
            const Source = models("Source");
    
            async.eachLimit(this.results, 1, (result, callback) => {
    Severity: Minor
    Found in schemas/ArtworkImport.js - About 1 hr to fix

      TODO found
      Open

      // TODO(jeresig): Remove this.
      Severity: Minor
      Found in schemas/ArtworkImport.js by fixme

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      Object.assign(ArtworkImport.statics, {
          fromFile(fileName, source) {
              const ArtworkImport = models("ArtworkImport");
              return new ArtworkImport({source, fileName});
          },
      Severity: Major
      Found in schemas/ArtworkImport.js and 1 other location - About 2 hrs to fix
      schemas/ImageImport.js on lines 224..234

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 90.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      const req = {
          format: (msg, fields) =>
              msg.replace(/%\((.*?)\)s/g, (all, name) => fields[name]),
          gettext: (msg) => msg,
          lang: "en",
      Severity: Minor
      Found in schemas/ArtworkImport.js and 1 other location - About 40 mins to fix
      tests/init.js on lines 886..891

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 49.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          {
              id: "similarity.sync.completed",
              name: (req) => req.gettext("Completed."),
              advance(batch, callback) {
                  // NOTE(jeresig): Currently nothing needs to be done to finish
      Severity: Minor
      Found in schemas/ArtworkImport.js and 1 other location - About 40 mins to fix
      schemas/ImageImport.js on lines 28..36

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          {
              id: "import.completed",
              name: (req) => req.gettext("Awaiting similarity sync..."),
              advance(batch, callback) {
                  batch.updateSimilarity(callback);
      Severity: Minor
      Found in schemas/ArtworkImport.js and 2 other locations - About 30 mins to fix
      schemas/ArtworkImport.js on lines 12..18
      schemas/ImageImport.js on lines 17..23

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          {
              id: "started",
              name: (req) => req.gettext("Awaiting processing..."),
              advance(batch, callback) {
                  batch.processArtworks(callback);
      Severity: Minor
      Found in schemas/ArtworkImport.js and 2 other locations - About 30 mins to fix
      schemas/ArtworkImport.js on lines 34..40
      schemas/ImageImport.js on lines 17..23

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status