Sign upLogin

jeresig/pharos-images

View on GitHub
Star
schemas/Image.js

Summary

Maintainability
C
1 day
Test Coverage

File Image.js has 381 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"use strict";

const fs = require("fs");
const path = require("path");
Severity: Minor
Found in schemas/Image.js - About 5 hrs to fix

    Function fromFile has 56 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        fromFile(batch, file, callback) {
        const Image = models("Image");
        const Source = models("Source");

        const fileName = path.basename(file);
    Severity: Major
    Found in schemas/Image.js - About 2 hrs to fix

      Function updateSimilarity has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          updateSimilarity(callback) {
        // Skip small images
        if (!this.canIndex()) {
            return process.nextTick(callback);
        }
      Severity: Minor
      Found in schemas/Image.js - About 1 hr to fix

        Function updateSimilarity has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            updateSimilarity(callback) {
        models("Image").findOne({
            needsSimilarUpdate: true,
        }, (err, image) => {
            if (err || !image) {
        Severity: Minor
        Found in schemas/Image.js - About 1 hr to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                          models("Image").findOne({
                    hash: match.id,
                }, (err, image) => {
                    if (err || !image) {
                        return callback();
          Severity: Major
          Found in schemas/Image.js and 1 other location - About 1 hr to fix
          schemas/UploadImage.js on lines 109..120

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 66.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              similarImages: [{
        // The ID of the visually similar image
        _id: {
            type: String,
            required: true,
          Severity: Minor
          Found in schemas/Image.js and 1 other location - About 50 mins to fix
          schemas/UploadImage.js on lines 65..78

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 51.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status