Sign upLogin

jeyroik/df-applications

View on GitHub
Star

Showing 7 of 11 total issues

Function __invoke has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    public function __invoke(IInstanceInfo $info)
    {
        $delta = $info->getDelta();

        if (!empty($delta)) {
Severity: Minor
Found in src/components/plugins/applications/PluginUpdateAppInfoDelta.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method updateInstanceVersion has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function updateInstanceVersion(string $instanceId): bool
    {
        $instance = $this->getInstanceById($instanceId);
        $app = $instance->getApplication();
Severity: Minor
Found in src/components/instances/InstanceService.php - About 1 hr to fix

    Method execute has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function execute(InputInterface $input, OutputInterface $output)
    {
        $path = $input->getOption(static::OPTION__PATH);

        $reader = new AppReader([
    Severity: Minor
    Found in src/components/commands/InstallAppsCommand.php - About 1 hr to fix

      Method installApp has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function installApp(string $id): bool
    {
        $reader = new AppReader();
        $app = $reader->getAppById($id);
        $packageName = $app->getPackage();
      Severity: Minor
      Found in src/components/applications/AppWriter.php - About 1 hr to fix

        Function updateInstanceVersion has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function updateInstanceVersion(string $instanceId): bool
    {
        $instance = $this->getInstanceById($instanceId);
        $app = $instance->getApplication();
        Severity: Minor
        Found in src/components/instances/InstanceService.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function decryptOptions has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public static function decryptOptions(IHaveOptions|IHasName &$item = null): void
    {
        if (!$item) {
            return;
        }
        Severity: Minor
        Found in src/components/applications/options/OptionItem.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function updateInstance has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public function updateInstance(IInstance &$instance, array $data, array $options): bool
    {
        $srcOptions = $instance->getOptions();
        foreach ($options as $name => $value) {
            if (isset($srcOptions[$name])) {
        Severity: Minor
        Found in src/components/instances/InstanceService.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language