jfinkhaeuser/unobtainium-faraday

View on GitHub

Showing 3 of 3 total issues

Method resolve_ssl_option has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def resolve_ssl_option(opts, path, pattern, klass, match_index = 0)
          # Ignore if the path doesn't exist
          if opts.nil? or opts[path].nil?
            return
          end
Severity: Minor
Found in lib/unobtainium-faraday/driver.rb - About 1 hr to fix

    Method resolve_ssl_option has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

            def resolve_ssl_option(opts, path, pattern, klass, match_index = 0)
              # Ignore if the path doesn't exist
              if opts.nil? or opts[path].nil?
                return
              end
    Severity: Minor
    Found in lib/unobtainium-faraday/driver.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method resolve_ssl_option has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            def resolve_ssl_option(opts, path, pattern, klass, match_index = 0)
    Severity: Minor
    Found in lib/unobtainium-faraday/driver.rb - About 35 mins to fix
      Severity
      Category
      Status
      Source
      Language