Showing 8 of 18 total issues
Method update has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring. Open
def update
oldE = Marshal::load(Marshal.dump(@event))
@event.update(event_params)
@event.editable = true;
create_new_client(@event.new_name, @event.new_email)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method create has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring. Open
def create
@event = Event.new(event_params)
@event.editable = true;
if @event.users.blank?
@event.users = [current_user]- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method update_variables has 58 lines of code (exceeds 25 allowed). Consider refactoring. Open
def update_variables(current_user)
if current_user.name == self.counselor and not self.users.include?(current_user)
self.users << current_user
end
Method create has 42 lines of code (exceeds 25 allowed). Consider refactoring. Open
def create
@event = Event.new(event_params)
@event.editable = true;
if @event.users.blank?
@event.users = [current_user]Method update has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
def update
oldE = Marshal::load(Marshal.dump(@event))
@event.update(event_params)
@event.editable = true;
create_new_client(@event.new_name, @event.new_email)Method update_variables has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def update_variables(current_user)
if current_user.name == self.counselor and not self.users.include?(current_user)
self.users << current_user
end
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method return_counselor_lists has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def return_counselor_lists(event_users)
@counselors = ""
event_users.each do | counselor|
if counselor == @event.users.last
if counselor != @event.users.first- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method create_new_client has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def create_new_client(name, email)
unless name.blank? || email.blank? || Client.where(["name = ? and email = ?", name, email]).length > 0
new_client = Client.create(name: name, email: email)
if new_client.valid?
@event.clients << new_client- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"