Sign upLogin

jmdobry/reheat

View on GitHub
Star
lib/collection/static/getAll.js

Summary

Maintainability
F
1 wk
Test Coverage

Function exports has 146 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function (container, Promise, utils, errors) {
  var errorPrefix = 'Collection.getAll(keys, index[, options][, cb]): ';
  var IllegalArgumentError = errors.IllegalArgumentError;
  var RuntimeError = errors.RuntimeError;
Severity: Major
Found in lib/collection/static/getAll.js - About 5 hrs to fix

    Function getAll has 140 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      function getAll(keys, index, options, cb) {
    var Collection = this;
    var models = container.get('models');
    var Model;
    Severity: Major
    Found in lib/collection/static/getAll.js - About 5 hrs to fix

      Function sanitize has 112 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          return Promise.resolve().then(function sanitize() {
      if (!utils.isArray(keys)) {
        throw new IllegalArgumentError(errorPrefix + 'keys: Must be a string or an array!', { actual: typeof keys, expected: 'string|array' });
      } else if (!utils.isString(index) && !utils.isObject(index)) {
        throw new IllegalArgumentError(errorPrefix + 'index: Must be a string or an object!', { actual: typeof index, expected: 'string|object' });
      Severity: Major
      Found in lib/collection/static/getAll.js - About 4 hrs to fix

        Function exports has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
        Open

        module.exports = function (container, Promise, utils, errors) {
  var errorPrefix = 'Collection.getAll(keys, index[, options][, cb]): ';
  var IllegalArgumentError = errors.IllegalArgumentError;
  var RuntimeError = errors.RuntimeError;
        Severity: Minor
        Found in lib/collection/static/getAll.js - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid deeply nested control flow statements.
        Open

                            if (newModels[localKey].relation === 'hasOne' && localValue.length) {
                      doc[localKey] = new models[newModels[localKey].modelName](localValue[0]);
                    } else {
                      doc[localKey] = new models[newModels[localKey].modelName].collection(localValue);
                    }
        Severity: Major
        Found in lib/collection/static/getAll.js - About 45 mins to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                if (options.with && options.with.length) {
        query = query.map(function (doc) {
          if (Model.relations.belongsTo) {
            utils.forOwn(Model.relations.belongsTo, function (relation, modelName) {
              if (!models[modelName]) {
          Severity: Major
          Found in lib/collection/static/getAll.js and 1 other location - About 4 days to fix
          lib/collection/static/findAll.js on lines 40..104

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 728.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                return Model.connection.run(query, options)
        .then(function (cursor) {
          if (options.profile) {
            profile = cursor.profile;
            cursor = cursor.result;
          Severity: Major
          Found in lib/collection/static/getAll.js and 1 other location - About 2 days to fix
          lib/collection/static/findAll.js on lines 138..176

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 413.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                } else if (!utils.isString(index) && !utils.isObject(index)) {
        throw new IllegalArgumentError(errorPrefix + 'index: Must be a string or an object!', { actual: typeof index, expected: 'string|object' });
      } else if (!utils.isObject(options)) {
        throw new IllegalArgumentError(errorPrefix + 'options: Must be an object!', { actual: typeof options, expected: 'object' });
      }
          Severity: Major
          Found in lib/collection/static/getAll.js and 1 other location - About 3 hrs to fix
          lib/model/prototype/load.js on lines 79..83

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 99.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              if (this.model) {
      Model = this.model;
    } else if (this.collection) {
      Model = this;
      Collection = Model.collection;
          Severity: Minor
          Found in lib/collection/static/getAll.js and 1 other location - About 50 mins to fix
          lib/collection/static/findAll.js on lines 14..19

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 52.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 6 locations. Consider refactoring.
          Open

              if (cb && !utils.isFunction(cb)) {
      throw new IllegalArgumentError(errorPrefix + 'cb: Must be a function!', { actual: typeof cb, expected: 'function' });
    }
          Severity: Major
          Found in lib/collection/static/getAll.js and 5 other locations - About 35 mins to fix
          lib/collection/static/findAll.js on lines 274..276
          lib/model/prototype/clear.js on lines 68..70
          lib/model/prototype/load.js on lines 74..76
          lib/model/prototype/set.js on lines 119..121
          lib/model/prototype/unset.js on lines 72..74

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status