Sign upLogin

jmdobry/reheat

View on GitHub
Star
lib/model/static/findOne.js

Summary

Maintainability
D
2 days
Test Coverage

Function exports has 133 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function (container, Promise, utils, errors) {
  /**
   * @doc method
   * @id Model.static_methods:findOne
   * @name findOne
Severity: Major
Found in lib/model/static/findOne.js - About 5 hrs to fix

    Function findOne has 130 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      function findOne(primaryKey, options, cb) {
    var models = container.get('models');
    var newModels = {};
    var merge = {};
    var query;
    Severity: Major
    Found in lib/model/static/findOne.js - About 5 hrs to fix

      Avoid deeply nested control flow statements.
      Open

                          if (newModels[localKey].relation === 'hasOne' && localValue.length) {
                      doc[localKey] = new models[newModels[localKey].modelName](localValue[0]);
                    } else {
                      doc[localKey] = new models[newModels[localKey].modelName].collection(localValue);
                    }
      Severity: Major
      Found in lib/model/static/findOne.js - About 45 mins to fix

        Function exports has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        module.exports = function (container, Promise, utils, errors) {
  /**
   * @doc method
   * @id Model.static_methods:findOne
   * @name findOne
        Severity: Minor
        Found in lib/model/static/findOne.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                if (!utils.isString(primaryKey)) {
          throw new errors.IllegalArgumentError(errorPrefix + 'primaryKey: Must be a string!', { actual: typeof primaryKey, expected: 'string' });
        } else if (!utils.isObject(options)) {
          throw new errors.IllegalArgumentError(errorPrefix + 'options: Must be an object!', { actual: typeof options, expected: 'object' });
        } else if (options.with && !utils.isArray(options.with)) {
        Severity: Major
        Found in lib/model/static/findOne.js and 1 other location - About 6 hrs to fix
        lib/model/static/destroyOne.js on lines 74..80

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 156.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 5 locations. Consider refactoring.
        Open

            if (cb && !utils.isFunction(cb)) {
      throw new errors.IllegalArgumentError(errorPrefix + 'cb: Must be a function!', { actual: typeof cb, expected: 'function' });
    }
        Severity: Major
        Found in lib/model/static/findOne.js and 4 other locations - About 45 mins to fix
        lib/connection/index.js on lines 163..165
        lib/model/prototype/destroy.js on lines 66..68
        lib/model/prototype/save.js on lines 97..99
        lib/model/static/destroyOne.js on lines 69..71

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status