Sign upLogin

jmdobry/reheat

View on GitHub
Star
old_test/reheat/model/prototype/clear.test.js

Summary

Maintainability
D
1 day
Test Coverage

Function validateWithError has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    validateWithError: function (test) {
        test.expect(6);

        var instance = {
            attributes: {
Severity: Minor
Found in old_test/reheat/model/prototype/clear.test.js - About 1 hr to fix

    Function options has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        options: function (test) {
        test.expect(6);

        var instance = {
            attributes: {
    Severity: Minor
    Found in old_test/reheat/model/prototype/clear.test.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  if (support.TYPES_EXCEPT_OBJECT[i] && support.TYPES_EXCEPT_OBJECT[i] !== true && typeof support.TYPES_EXCEPT_OBJECT[i] !== 'function') {
                queue.push((function (j) {
                    return instance.clear(support.TYPES_EXCEPT_OBJECT[i]).then(function () {
                        support.fail('Should have failed on ' + support.TYPES_EXCEPT_OBJECT[j]);
                    })
      Severity: Major
      Found in old_test/reheat/model/prototype/clear.test.js and 1 other location - About 7 hrs to fix
      old_test/reheat/model/prototype/save.test.js on lines 290..303

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 176.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                  instance.clear(true).catch(errors.ValidationError, function (err) {
                test.equal(err.type, 'ValidationError');
                test.equal(instance.constructor.schema.validate.callCount, 2);
                test.deepEqual(instance.attributes, {
                    name: 'John'
      Severity: Major
      Found in old_test/reheat/model/prototype/clear.test.js and 1 other location - About 2 hrs to fix
      old_test/reheat/model/prototype/unset.test.js on lines 172..179

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 89.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

              instance.constructor.schema.validate = function (attrs, cb) {
            cb(new errors.ValidationError('error', { error: 'testError' }));
        };
      Severity: Minor
      Found in old_test/reheat/model/prototype/clear.test.js and 2 other locations - About 40 mins to fix
      old_test/reheat/model/prototype/set.test.js on lines 246..248
      old_test/reheat/model/prototype/unset.test.js on lines 160..162

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                  instance.clear(true).then(function (instance) {
                test.equal(instance.constructor.schema.validate.callCount, 2);
                test.done();
            });
      Severity: Minor
      Found in old_test/reheat/model/prototype/clear.test.js and 1 other location - About 35 mins to fix
      old_test/reheat/model/prototype/unset.test.js on lines 141..144

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status