Sign upLogin

jmdobry/reheat

View on GitHub
Star
old_test/reheat/model/prototype/destroy.test.js

Summary

Maintainability
F
3 days
Test Coverage

Function softDeleteTimestamps has 99 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    softDeleteTimestamps: function (test) {
        test.expect(7);

        var instance = {
            attributes: {
Severity: Major
Found in old_test/reheat/model/prototype/destroy.test.js - About 3 hrs to fix

    File destroy.test.js has 327 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*jshint loopfunc:true*/

var SandboxedModule = require('sandboxed-module'),
    errors = require('../../../../../build/instrument/lib/support/errors'),
    Promise = require('bluebird'),
    Severity: Minor
    Found in old_test/reheat/model/prototype/destroy.test.js - About 3 hrs to fix

      Function softDelete has 84 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          softDelete: function (test) {
        test.expect(7);

        var instance = {
            attributes: {
      Severity: Major
      Found in old_test/reheat/model/prototype/destroy.test.js - About 3 hrs to fix

        Function normal has 69 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            normal: function (test) {
        test.expect(7);

        var instance = {
            attributes: {
        Severity: Major
        Found in old_test/reheat/model/prototype/destroy.test.js - About 2 hrs to fix

          Function normalIsNew has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              normalIsNew: function (test) {
        test.expect(3);

        var instance = {
            attributes: {
          Severity: Minor
          Found in old_test/reheat/model/prototype/destroy.test.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    var instance = {
            attributes: {
                name: 'John',
                id: 2
            },
            Severity: Major
            Found in old_test/reheat/model/prototype/destroy.test.js and 1 other location - About 3 hrs to fix
            old_test/reheat/model/prototype/destroy.test.js on lines 262..281

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 95.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    var instance = {
            attributes: {
                name: 'John',
                id: 2
            },
            Severity: Major
            Found in old_test/reheat/model/prototype/destroy.test.js and 1 other location - About 3 hrs to fix
            old_test/reheat/model/prototype/destroy.test.js on lines 157..176

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 95.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                            test.deepEqual(instance.meta, {
                    old_val: {
                        name: 'John',
                        id: 2,
                        updated: 5,
            Severity: Major
            Found in old_test/reheat/model/prototype/destroy.test.js and 1 other location - About 1 hr to fix
            old_test/reheat/model/prototype/destroy.test.js on lines 212..226

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 74.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        test.deepEqual(instance.meta, {
                old_val: {
                    name: 'John',
                    id: 2,
                    updated: 5,
            Severity: Major
            Found in old_test/reheat/model/prototype/destroy.test.js and 1 other location - About 1 hr to fix
            old_test/reheat/model/prototype/destroy.test.js on lines 240..254

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 74.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                            test.deepEqual(instance.meta, {
                    old_val: {
                        name: 'John',
                        id: 2
                    },
            Severity: Major
            Found in old_test/reheat/model/prototype/destroy.test.js and 1 other location - About 1 hr to fix
            old_test/reheat/model/prototype/destroy.test.js on lines 311..322

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 59.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        test.deepEqual(instance.meta, {
                old_val: {
                    name: 'John',
                    id: 2
                },
            Severity: Major
            Found in old_test/reheat/model/prototype/destroy.test.js and 1 other location - About 1 hr to fix
            old_test/reheat/model/prototype/destroy.test.js on lines 333..344

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 59.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        instance.destroy().then(function (instance) {
                test.deepEqual(instance.attributes, {
                    name: 'John'
                });
                test.done();
            Severity: Major
            Found in old_test/reheat/model/prototype/destroy.test.js and 1 other location - About 1 hr to fix
            old_test/reheat/model/prototype/save.test.js on lines 106..111

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 56.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status