Sign upLogin

jmdobry/reheat

View on GitHub
Star
old_test/reheat/model/prototype/set.test.js

Summary

Maintainability
C
1 day
Test Coverage

Function nestedObject has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    nestedObject: function (test) {
        test.expect(3);

        var instance = {
            attributes: {
Severity: Minor
Found in old_test/reheat/model/prototype/set.test.js - About 1 hr to fix

    Function key has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        key: function (test) {
        test.expect(12);

        var instance = {
            attributes: {
    Severity: Minor
    Found in old_test/reheat/model/prototype/set.test.js - About 1 hr to fix

      Function options has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          options: function (test) {
        test.expect(6);

        var instance = {
            attributes: {
      Severity: Minor
      Found in old_test/reheat/model/prototype/set.test.js - About 1 hr to fix

        Function simpleNestedValidateTrue has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            simpleNestedValidateTrue: function (test) {
        test.expect(4);

        var instance = {
            attributes: {
        Severity: Minor
        Found in old_test/reheat/model/prototype/set.test.js - About 1 hr to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  instance.set('address.state', 'TX', function (err, instance) {
            test.ifError(err);
            test.deepEqual(instance.attributes, {
                address: {
                    state: 'TX'
          Severity: Major
          Found in old_test/reheat/model/prototype/set.test.js and 1 other location - About 1 hr to fix
          old_test/reheat/model/prototype/set.test.js on lines 78..87

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 57.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  }, function (err, instance) {
            test.ifError(err);
            test.deepEqual(instance.attributes, {
                address: {
                    state: 'TX'
          Severity: Major
          Found in old_test/reheat/model/prototype/set.test.js and 1 other location - About 1 hr to fix
          old_test/reheat/model/prototype/set.test.js on lines 46..55

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 57.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  instance.set('name', 'Sally', function (err, instance) {
            test.ifError(err);
            test.deepEqual(instance.attributes, { name: 'Sally' });

            test.done();
          Severity: Minor
          Found in old_test/reheat/model/prototype/set.test.js and 1 other location - About 50 mins to fix
          old_test/reheat/model/prototype/set.test.js on lines 100..107

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 51.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  instance.set('name', 'Sally', true, function (err, instance) {
            test.ifError(err);
            test.deepEqual(instance.attributes, {
                name: 'Sally'
            });
          Severity: Minor
          Found in old_test/reheat/model/prototype/set.test.js and 1 other location - About 50 mins to fix
          old_test/reheat/model/prototype/set.test.js on lines 22..27

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 51.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

                  instance.constructor.schema.validate = function (attrs, cb) {
            cb(new errors.ValidationError('error', { error: 'testError' }));
        };
          Severity: Minor
          Found in old_test/reheat/model/prototype/set.test.js and 2 other locations - About 40 mins to fix
          old_test/reheat/model/prototype/clear.test.js on lines 133..135
          old_test/reheat/model/prototype/unset.test.js on lines 160..162

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status