jmdobry/reheat

View on GitHub
old_test/reheat/model/static/filter.test.js

Summary

Maintainability
F
2 wks
Test Coverage

File filter.test.js has 478 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*jshint loopfunc:true*/

var filter = require('../../../../../build/instrument/lib/model/static/filter'),
    errors = require('../../../../../build/instrument/lib/support/errors'),
    support = require('../../../../support/support'),
Severity: Minor
Found in old_test/reheat/model/static/filter.test.js - About 7 hrs to fix

    Function profile has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        profile: function (test) {
            test.expect(5);
    
            function Model(attrs) {
                this.attributes = attrs;
    Severity: Minor
    Found in old_test/reheat/model/static/filter.test.js - About 1 hr to fix

      Function limit has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          limit: function (test) {
              test.expect(5);
      
              function Model(attrs) {
                  this.attributes = attrs;
      Severity: Minor
      Found in old_test/reheat/model/static/filter.test.js - About 1 hr to fix

        Function pluck has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            pluck: function (test) {
                test.expect(5);
        
                function Model(attrs) {
                    this.attributes = attrs;
        Severity: Minor
        Found in old_test/reheat/model/static/filter.test.js - About 1 hr to fix

          Function orderBy has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              orderBy: function (test) {
                  test.expect(5);
          
                  function Model(attrs) {
                      this.attributes = attrs;
          Severity: Minor
          Found in old_test/reheat/model/static/filter.test.js - About 1 hr to fix

            Function skip has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                skip: function (test) {
                    test.expect(5);
            
                    function Model(attrs) {
                        this.attributes = attrs;
            Severity: Minor
            Found in old_test/reheat/model/static/filter.test.js - About 1 hr to fix

              Function pluckMultiple has 28 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  pluckMultiple: function (test) {
                      test.expect(5);
              
                      function Model(attrs) {
                          this.attributes = attrs;
              Severity: Minor
              Found in old_test/reheat/model/static/filter.test.js - About 1 hr to fix

                Function raw has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    raw: function (test) {
                        test.expect(5);
                
                        function Model(attrs) {
                            this.attributes = attrs;
                Severity: Minor
                Found in old_test/reheat/model/static/filter.test.js - About 1 hr to fix

                  Function orderByArray has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      orderByArray: function (test) {
                          test.expect(5);
                  
                          function Model(attrs) {
                              this.attributes = attrs;
                  Severity: Minor
                  Found in old_test/reheat/model/static/filter.test.js - About 1 hr to fix

                    Function options has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        options: function (test) {
                            test.expect(8);
                    
                            function Model(attrs) {
                                this.attributes = attrs;
                    Severity: Minor
                    Found in old_test/reheat/model/static/filter.test.js - About 1 hr to fix

                      Function whereError has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          whereError: function (test) {
                              test.expect(10);
                      
                              function Model(attrs) {
                                  this.attributes = attrs;
                      Severity: Minor
                      Found in old_test/reheat/model/static/filter.test.js - About 1 hr to fix

                        Function predicate has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            predicate: function (test) {
                                test.expect(10);
                        
                                function Model(attrs) {
                                    this.attributes = attrs;
                        Severity: Minor
                        Found in old_test/reheat/model/static/filter.test.js - About 1 hr to fix

                          Function skipError has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              skipError: function (test) {
                                  test.expect(8);
                          
                                  function Model(attrs) {
                                      this.attributes = attrs;
                          Severity: Minor
                          Found in old_test/reheat/model/static/filter.test.js - About 1 hr to fix

                            Function pluckError has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                pluckError: function (test) {
                                    test.expect(10);
                            
                                    function Model(attrs) {
                                        this.attributes = attrs;
                            Severity: Minor
                            Found in old_test/reheat/model/static/filter.test.js - About 1 hr to fix

                              Function limitError has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                  limitError: function (test) {
                                      test.expect(8);
                              
                                      function Model(attrs) {
                                          this.attributes = attrs;
                              Severity: Minor
                              Found in old_test/reheat/model/static/filter.test.js - About 1 hr to fix

                                Function where has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                    where: function (test) {
                                        test.expect(3);
                                
                                        function Model(attrs) {
                                            this.attributes = attrs;
                                Severity: Minor
                                Found in old_test/reheat/model/static/filter.test.js - About 1 hr to fix

                                  Similar blocks of code found in 3 locations. Consider refactoring.
                                  Open

                                      limitError: function (test) {
                                          test.expect(8);
                                  
                                          function Model(attrs) {
                                              this.attributes = attrs;
                                  Severity: Major
                                  Found in old_test/reheat/model/static/filter.test.js and 2 other locations - About 2 days to fix
                                  old_test/reheat/model/static/filter.test.js on lines 106..139
                                  old_test/reheat/model/static/filter.test.js on lines 306..339

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 357.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 3 locations. Consider refactoring.
                                  Open

                                      whereError: function (test) {
                                          test.expect(10);
                                  
                                          function Model(attrs) {
                                              this.attributes = attrs;
                                  Severity: Major
                                  Found in old_test/reheat/model/static/filter.test.js and 2 other locations - About 2 days to fix
                                  old_test/reheat/model/static/filter.test.js on lines 239..272
                                  old_test/reheat/model/static/filter.test.js on lines 306..339

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 357.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 3 locations. Consider refactoring.
                                  Open

                                      skipError: function (test) {
                                          test.expect(8);
                                  
                                          function Model(attrs) {
                                              this.attributes = attrs;
                                  Severity: Major
                                  Found in old_test/reheat/model/static/filter.test.js and 2 other locations - About 2 days to fix
                                  old_test/reheat/model/static/filter.test.js on lines 106..139
                                  old_test/reheat/model/static/filter.test.js on lines 239..272

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 357.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                      skip: function (test) {
                                          test.expect(5);
                                  
                                          function Model(attrs) {
                                              this.attributes = attrs;
                                  Severity: Major
                                  Found in old_test/reheat/model/static/filter.test.js and 1 other location - About 1 day to fix
                                  old_test/reheat/model/static/filter.test.js on lines 206..238

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 351.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                      limit: function (test) {
                                          test.expect(5);
                                  
                                          function Model(attrs) {
                                              this.attributes = attrs;
                                  Severity: Major
                                  Found in old_test/reheat/model/static/filter.test.js and 1 other location - About 1 day to fix
                                  old_test/reheat/model/static/filter.test.js on lines 273..305

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 351.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Identical blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                          Model.connection = {
                                              run: Promise.promisify(function (query, options, next) {
                                                  next(null, {
                                                      profile: {},
                                                      value: {
                                  Severity: Major
                                  Found in old_test/reheat/model/static/filter.test.js and 1 other location - About 3 hrs to fix
                                  old_test/reheat/model/static/getAll.test.js on lines 48..62

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 98.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Identical blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                          Model.connection = {
                                              run: Promise.promisify(function (query, options, next) {
                                                  next(null, {
                                                      toArray: function (cb) {
                                                          cb(null, [
                                  Severity: Major
                                  Found in old_test/reheat/model/static/filter.test.js and 1 other location - About 1 hr to fix
                                  old_test/reheat/model/static/getAll.test.js on lines 18..28

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 74.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Identical blocks of code found in 3 locations. Consider refactoring.
                                  Open

                                              Model.filter({ pluck: ['name', 'id'] }, { raw: true }).then(function (instances) {
                                                  test.deepEqual(instances[0], { id: 5, name: 'John' });
                                                  test.deepEqual(instances[1], { id: 6, name: 'Sally' });
                                                  test.done();
                                              });
                                  Severity: Major
                                  Found in old_test/reheat/model/static/filter.test.js and 2 other locations - About 1 hr to fix
                                  old_test/reheat/model/static/filter.test.js on lines 466..470
                                  old_test/reheat/model/static/getAll.test.js on lines 134..138

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 72.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Identical blocks of code found in 3 locations. Consider refactoring.
                                  Open

                                              Model.filter({}, { raw: true }).then(function (instances) {
                                                  test.deepEqual(instances[0], { id: 5, name: 'John' });
                                                  test.deepEqual(instances[1], { id: 6, name: 'Sally' });
                                                  test.done();
                                              });
                                  Severity: Major
                                  Found in old_test/reheat/model/static/filter.test.js and 2 other locations - About 1 hr to fix
                                  old_test/reheat/model/static/filter.test.js on lines 399..403
                                  old_test/reheat/model/static/getAll.test.js on lines 134..138

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 72.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Identical blocks of code found in 3 locations. Consider refactoring.
                                  Open

                                              Model.filter({}).then(function (instances) {
                                                  test.deepEqual(instances[0].attributes, { id: 5, name: 'John' });
                                                  test.done();
                                              });
                                  Severity: Major
                                  Found in old_test/reheat/model/static/filter.test.js and 2 other locations - About 40 mins to fix
                                  old_test/reheat/model/static/filter.test.js on lines 100..103
                                  old_test/reheat/model/static/getAll.test.js on lines 33..36

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 49.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Identical blocks of code found in 3 locations. Consider refactoring.
                                  Open

                                              Model.filter({ where: { name: 'John' }}).then(function (instances) {
                                                  test.deepEqual(instances[0].attributes, { id: 5, name: 'John' });
                                                  test.done();
                                              });
                                  Severity: Major
                                  Found in old_test/reheat/model/static/filter.test.js and 2 other locations - About 40 mins to fix
                                  old_test/reheat/model/static/filter.test.js on lines 33..36
                                  old_test/reheat/model/static/getAll.test.js on lines 33..36

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 49.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  There are no issues that match your filters.

                                  Category
                                  Status