jmdobry/reheat

View on GitHub
old_test/reheat/model/static/getAll.test.js

Summary

Maintainability
D
2 days
Test Coverage

Function profile has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    profile: function (test) {
        test.expect(5);

        function Model(attrs) {
            this.attributes = attrs;
Severity: Minor
Found in old_test/reheat/model/static/getAll.test.js - About 1 hr to fix

    Function raw has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        raw: function (test) {
            test.expect(5);
    
            function Model(attrs) {
                this.attributes = attrs;
    Severity: Minor
    Found in old_test/reheat/model/static/getAll.test.js - About 1 hr to fix

      Function normalKeyArray has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          normalKeyArray: function (test) {
              test.expect(5);
      
              function Model(attrs) {
                  this.attributes = attrs;
      Severity: Minor
      Found in old_test/reheat/model/static/getAll.test.js - About 1 hr to fix

        Function options has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            options: function (test) {
                test.expect(8);
        
                function Model(attrs) {
                    this.attributes = attrs;
        Severity: Minor
        Found in old_test/reheat/model/static/getAll.test.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  for (var i = 0; i < support.TYPES_EXCEPT_STRING_OR_OBJECT.length; i++) {
                      queue.push((function (j) {
                          return Model.getAll('5', support.TYPES_EXCEPT_STRING_OR_OBJECT[j]).then(function () {
                              support.fail('Should have failed on ' + support.TYPES_EXCEPT_STRING_OR_OBJECT[j]);
                          })
          Severity: Major
          Found in old_test/reheat/model/static/getAll.test.js and 1 other location - About 7 hrs to fix
          old_test/reheat/model/static/get.test.js on lines 161..174

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 176.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  Model.connection = {
                      run: Promise.promisify(function (query, options, next) {
                          next(null, {
                              profile: {},
                              value: {
          Severity: Major
          Found in old_test/reheat/model/static/getAll.test.js and 1 other location - About 3 hrs to fix
          old_test/reheat/model/static/filter.test.js on lines 48..62

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 98.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  Model.connection = {
                      run: Promise.promisify(function (query, options, next) {
                          next(null, {
                              toArray: function (cb) {
                                  cb(null, [
          Severity: Major
          Found in old_test/reheat/model/static/getAll.test.js and 1 other location - About 1 hr to fix
          old_test/reheat/model/static/filter.test.js on lines 18..28

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 74.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

                      Model.getAll(['5', '6'], { index: 'id' }, { raw: true }).then(function (instances) {
                          test.deepEqual(instances[0], { id: 5, name: 'John' });
                          test.deepEqual(instances[1], { id: 6, name: 'Sally' });
                          test.done();
                      });
          Severity: Major
          Found in old_test/reheat/model/static/getAll.test.js and 2 other locations - About 1 hr to fix
          old_test/reheat/model/static/filter.test.js on lines 399..403
          old_test/reheat/model/static/filter.test.js on lines 466..470

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 72.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

                      Model.getAll('5', 'id').then(function (instances) {
                          test.deepEqual(instances[0].attributes, { id: 5, name: 'John' });
                          test.done();
                      });
          Severity: Major
          Found in old_test/reheat/model/static/getAll.test.js and 2 other locations - About 40 mins to fix
          old_test/reheat/model/static/filter.test.js on lines 33..36
          old_test/reheat/model/static/filter.test.js on lines 100..103

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status