Sign upLogin

jmeas/redux-resource

View on GitHub
Star
packages/redux-resource/src/resource-reducer.js

Summary

Maintainability
D
2 days
Test Coverage

Function resourceReducer has 112 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function resourceReducer(resourceType, options = {}) {
  const { plugins = [], initialState = {} } = options;
  const defaultInitialState = generateDefaultInitialState();
  const initial = {
    ...defaultInitialState,
Severity: Major
Found in packages/redux-resource/src/resource-reducer.js - About 4 hrs to fix

    Function resourceReducer has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
    Open

    export default function resourceReducer(resourceType, options = {}) {
  const { plugins = [], initialState = {} } = options;
  const defaultInitialState = generateDefaultInitialState();
  const initial = {
    ...defaultInitialState,
    Severity: Minor
    Found in packages/redux-resource/src/resource-reducer.js - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function reducer has 72 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      return function reducer(state = initial, action) {
    if (process.env.NODE_ENV !== 'production') {
      if (
        action.type === 'REQUEST_PENDING' ||
        action.type === 'REQUEST_IDLE' ||
    Severity: Major
    Found in packages/redux-resource/src/resource-reducer.js - About 2 hrs to fix

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

            if (action.requestKey && typeof action.requestKey !== 'string') {
        warning(
          `An invalid requestKey property was included in an action with type ` +
            `"${action.type}". The requestKey property must be a string. ` +
            `For more information, refer to the documentation at: ` +
      Severity: Major
      Found in packages/redux-resource/src/resource-reducer.js and 3 other locations - About 1 hr to fix
      packages/redux-resource/src/resource-reducer.js on lines 92..100
      packages/redux-resource/src/resource-reducer.js on lines 112..120
      packages/redux-resource/src/resource-reducer.js on lines 122..130

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 73.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

            if (action.requestName && typeof action.requestName !== 'string') {
        warning(
          `An invalid requestName property was included in an action with type ` +
            `"${action.type}". The requestName property must be a string. ` +
            `For more information, refer to the documentation at: ` +
      Severity: Major
      Found in packages/redux-resource/src/resource-reducer.js and 3 other locations - About 1 hr to fix
      packages/redux-resource/src/resource-reducer.js on lines 92..100
      packages/redux-resource/src/resource-reducer.js on lines 102..110
      packages/redux-resource/src/resource-reducer.js on lines 122..130

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 73.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

            if (action.request && typeof action.request !== 'string') {
        warning(
          `An invalid request property was included in an action with type ` +
            `"${action.type}". The request property must be a string. ` +
            `For more information, refer to the documentation at: ` +
      Severity: Major
      Found in packages/redux-resource/src/resource-reducer.js and 3 other locations - About 1 hr to fix
      packages/redux-resource/src/resource-reducer.js on lines 102..110
      packages/redux-resource/src/resource-reducer.js on lines 112..120
      packages/redux-resource/src/resource-reducer.js on lines 122..130

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 73.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

            if (action.list && typeof action.list !== 'string') {
        warning(
          `An invalid list was included in an action with type ` +
            `"${action.type}". Lists must be strings.` +
            `For more information, refer to the documentation at: ` +
      Severity: Major
      Found in packages/redux-resource/src/resource-reducer.js and 3 other locations - About 1 hr to fix
      packages/redux-resource/src/resource-reducer.js on lines 92..100
      packages/redux-resource/src/resource-reducer.js on lines 102..110
      packages/redux-resource/src/resource-reducer.js on lines 112..120

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 73.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            if (
        action.type === 'REQUEST_PENDING' ||
        action.type === 'REQUEST_IDLE' ||
        action.type === 'REQUEST_FAILED' ||
        action.type === 'REQUEST_SUCCEEDED'
      Severity: Major
      Found in packages/redux-resource/src/resource-reducer.js and 1 other location - About 1 hr to fix
      packages/redux-resource/src/utils/reducer-generator.js on lines 49..58

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 61.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status