Sign upLogin

jmkim/laravel-entrust-gui

View on GitHub
Star

Showing 4 of 6 total issues

Method up has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function up()
    {
        // Create table for storing roles
        Schema::create('roles', function (Blueprint $table) {
            $table->increments('id');
Severity: Minor
Found in database/migrations/2015_08_06_174610_entrust_setup_tables.php - About 1 hr to fix

    Function update has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        public function update(array $attributes, $id)
    {
        $defaults = ['roles' => []];
        $attributes = array_merge($defaults, $attributes);
        $model = $this->find($id);
    Severity: Minor
    Found in src/Repositories/UserRepositoryEloquent.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method update has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function update(array $attributes, $id)
    {
        $defaults = ['roles' => []];
        $attributes = array_merge($defaults, $attributes);
        $model = $this->find($id);
    Severity: Minor
    Found in src/Repositories/UserRepositoryEloquent.php - About 1 hr to fix

      Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function __construct(Request $request, Config $config, $gateway, $resource, $relation)
      Severity: Minor
      Found in src/Http/Controllers/ManyToManyController.php - About 35 mins to fix
        Severity
        Category
        Status
        Source
        Language