Sign upLogin

joelibaceta/video-to-ascii

View on GitHub
Star

Showing 3 of 7 total issues

Function render has a Cognitive Complexity of 52 (exceeds 5 allowed). Consider refactoring.
Open

    def render(self, cap, output=None, output_format=None, with_audio=False):
        """
        Iterate each video frame to print a set of ascii chars

        This method reads each video frame from a opencv video capture
Severity: Minor
Found in video_to_ascii/render_strategy/ascii_strategy.py - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function play has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

def play(filename, strategy=None, output=None, output_format=None, play_audio=False):
Severity: Minor
Found in video_to_ascii/player.py - About 35 mins to fix

    Function convert_frame_pixels_to_ascii has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def convert_frame_pixels_to_ascii(self, frame, dimensions=DEFAULT_TERMINAL_SIZE, new_line_chars=False):
        """
        Replace all pixels with colored chars and return the resulting string

        This method iterates each pixel of one video frame
    Severity: Minor
    Found in video_to_ascii/render_strategy/ascii_strategy.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language