Sign upLogin

johackim/rdcli

View on GitHub
Star

Showing 3 of 3 total issues

Function download has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function download(link, callback) {
    log(`download file ${link}`);
    const filename = unescape(url.parse(link).pathname.split('/').pop());
    const file = `${process.cwd()}/${filename}`;
Severity: Minor
Found in src/download.js - About 1 hr to fix

    Function handleErrorMessage has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export default function handleErrorMessage(error) {
    const errorCode = error.error_code;

    switch (errorCode) {
    case 1:
    Severity: Minor
    Found in src/utils.js - About 1 hr to fix

      Function default has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      export default async function (url, opts = { method: 'GET' }) {
    const res = await fetch(url, {
        method: opts.method,
        headers: { 'Content-Type': 'application/x-www-form-urlencoded' },
        body: (typeof opts.body !== 'undefined' && opts.body.constructor.name === 'Buffer') ? opts.body : querystring.stringify(opts.body),
      Severity: Minor
      Found in src/fetch.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language