Sign upLogin

johnjones4/InBrief

View on GitHub
Star
src/ui/util/reducer.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function services has 92 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const services = (state = initialServicesState, action) => {
  switch (action.type) {
    case ACTIONS.SET_SERVICES:
      const newServices = action.services.slice(0)
      newServices.forEach((service) => {
Severity: Major
Found in src/ui/util/reducer.js - About 3 hrs to fix

    Function services has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

    const services = (state = initialServicesState, action) => {
  switch (action.type) {
    case ACTIONS.SET_SERVICES:
      const newServices = action.services.slice(0)
      newServices.forEach((service) => {
    Severity: Minor
    Found in src/ui/util/reducer.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

          return Object.assign({}, state, {
        services: newServices1
      })
    Severity: Major
    Found in src/ui/util/reducer.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return Object.assign({}, state, {
          services: newServices
        })
      Severity: Major
      Found in src/ui/util/reducer.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return state
        Severity: Major
        Found in src/ui/util/reducer.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return Object.assign({}, state, {
          services: newServices
        })
          Severity: Major
          Found in src/ui/util/reducer.js - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status