Sign upLogin

johnnyshields/naturalsort

View on GitHub
Star

Showing 2 of 2 total issues

Consider simplifying this complex logical expression.
Open

        if (ma[it] and mb[it]) and (ma[it][1] and mb[it][1]) and (NUMERIC.match ma[it][0] and NUMERIC.match mb[it][0])
          l = [ma[it][2].size,mb[it][2].size].max
          ret = [format(ma[it], l), format(mb[it], l)]
        else
          ret = [ma[it][0].downcase, mb[it][0].downcase]
Severity: Major
Found in lib/natural_sort/engine.rb - About 40 mins to fix

    Method check_regexp has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def check_regexp(sa, sb)
      ma, mb = multireg(REGEXP,sa), multireg(REGEXP,sb)
      it = 0
      equal = 0
      ret = ['', '']
    Severity: Minor
    Found in lib/natural_sort/engine.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language