jonpitch/danger-brewing

View on GitHub

Showing 5 of 132 total issues

Function stubApplicationFixture has 89 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function stubApplicationFixture() {
  return {
    beers: {
      '-KO1N4Ofi1IwSetMe9ta': {
        abv: 6.5,
Severity: Major
Found in tests/helpers/fixtures.js - About 3 hrs to fix

    Function save has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        save() {
          this.validate().then(({ m, validations }) => {
            const isValid = validations.get('isValid');
            if (isValid) {
              const {
    Severity: Minor
    Found in app/components/add-beer.js - About 1 hr to fix

      Function stubHubAndTapsFixture has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export function stubHubAndTapsFixture() {
        return {
          hubs: {
            '-KO1EJBmskdNLOc1S-4c': {
              humidity: 25,
      Severity: Minor
      Found in tests/helpers/fixtures.js - About 1 hr to fix

        Function save has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            save() {
              this.validate().then(({ m, validations }) => {
                const isValid = validations.get('isValid');
                if (isValid) {
                  const {
        Severity: Minor
        Found in app/components/add-tap.js - About 1 hr to fix

          Function save has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              save() {
                this.validate().then(({ m, validations }) => {
                  const isValid = validations.get('isValid');
                  if (isValid) {
                    const {
          Severity: Minor
          Found in app/components/add-sensor.js - About 1 hr to fix
            Severity
            Category
            Status
            Source
            Language