Sign upLogin

joola/joola

View on GitHub
Star
lib/discovery/providers/redis.js

Summary

Maintainability
C
1 day
Test Coverage

Function localApply has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

RedisDiscoveryProvider.prototype.localApply = function (storeVersion, key, callback) {
  if (typeof key === 'function') {
    callback = key;
    key = null;
  }
Severity: Minor
Found in lib/discovery/providers/redis.js - About 1 hr to fix

    Function set has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    RedisDiscoveryProvider.prototype.set = function (key, value, callback) {
  callback = callback || function () {
  };
  var self = this;
  key = encodeURI(key).replace('.', '_$_');
    Severity: Minor
    Found in lib/discovery/providers/redis.js - About 1 hr to fix

      Function storePopulate has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      RedisDiscoveryProvider.prototype.storePopulate = function (configuration, callback) {
  var self = this;
  self.logger.trace('Populating local configuration into central store, version [' + configuration.version + '].');
  var flatConfig = self.common.flatten(configuration);
  var calls = [];
      Severity: Minor
      Found in lib/discovery/providers/redis.js - About 1 hr to fix

        Function RedisDiscoveryProvider has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        function RedisDiscoveryProvider(options, helpers, callback) {
  if (!(this instanceof RedisDiscoveryProvider)) return new RedisDiscoveryProvider(options, helpers, callback);
  callback = callback || function () {
  };
  var self = this;
        Severity: Minor
        Found in lib/discovery/providers/redis.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        RedisDiscoveryProvider.prototype.get = function (key, callback) {
  var self = this;
  key = encodeURI(key).replace('.', '_$_');
  var result = self.common.flatGetSet(self._config, key.replace(/:/ig, '.'));
  if (callback && typeof callback === 'function')
        Severity: Major
        Found in lib/discovery/providers/redis.js and 1 other location - About 3 hrs to fix
        lib/discovery/providers/zookeeper.js on lines 159..166

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 107.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            }, function (err) {
      /* istanbul ignore if */
      if (err)
        return callback(err);
        Severity: Minor
        Found in lib/discovery/providers/redis.js and 1 other location - About 55 mins to fix
        lib/discovery/providers/redis.js on lines 101..108

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 54.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            }, function (err) {
      /* istanbul ignore if */
      if (err)
        return callback(err);
      self.localChange = true;
        Severity: Minor
        Found in lib/discovery/providers/redis.js and 1 other location - About 55 mins to fix
        lib/discovery/providers/redis.js on lines 60..68

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 54.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

          if (key)
    key = self.namespace + ':config:' + key + ':*';
  else
    key = self.namespace + ':config:*';
        Severity: Minor
        Found in lib/discovery/providers/redis.js and 1 other location - About 30 mins to fix
        lib/discovery/providers/zookeeper.js on lines 227..230

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status