Sign upLogin

joola/joola

View on GitHub
Star
lib/dispatch/beacon.js

Summary

Maintainability
D
3 days
Test Coverage

Function verify has 145 lines of code (exceeds 25 allowed). Consider refactoring.
Open

etl.verify = function(context, workspace, collection, documents, callback) {
  var _document;
  if (!Array.isArray(documents))
    documents = [documents];
Severity: Major
Found in lib/dispatch/beacon.js - About 5 hrs to fix

    File beacon.js has 370 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
 *  @title joola
 *  @overview the open-source data analytics framework
 *  @copyright Joola Smart Solutions, Ltd. <info@joo.la>
 *  @license GPL-3.0+ <http://spdx.org/licenses/GPL-3.0+>
    Severity: Minor
    Found in lib/dispatch/beacon.js - About 4 hrs to fix

      Function _route has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
      Open

        _route: function(req, res) {
    var _params = {}; //req.parsed;
    var context = {};
    context.user = req.user;
    _params.workspace = context.user.workspace;
      Severity: Minor
      Found in lib/dispatch/beacon.js - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function run has 55 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        run: function(context, workspace, collection, documents, options, callback) {

    if (typeof options === 'function') {
      callback = options;
      options = {};
      Severity: Major
      Found in lib/dispatch/beacon.js - About 2 hrs to fix

        Function load has 53 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        etl.load = function(context, workspace, collection, documents, options, callback) {
  joola.dispatch.collections.metadata(context, workspace, collection, ce.clone(documents[0]), function(err, meta, _collection) {
    if (err)
      return callback(err);
        Severity: Major
        Found in lib/dispatch/beacon.js - About 2 hrs to fix

          Function _route has 49 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            _route: function(req, res) {
    var _params = {}; //req.parsed;
    var context = {};
    context.user = req.user;
    _params.workspace = context.user.workspace;
          Severity: Minor
          Found in lib/dispatch/beacon.js - About 1 hr to fix

            Consider simplifying this complex logical expression.
            Open

                    if (!doc[_collection.time_field || 'timestamp'])
          doc[_collection.time_field || 'timestamp'] = new Date();
        else {
          doc[_collection.time_field || 'timestamp'] = new Date(doc[_collection.time_field || 'timestamp'].value || doc[_collection.time_field || 'timestamp']);
        }
            Severity: Major
            Found in lib/dispatch/beacon.js - About 1 hr to fix

              Function load has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              etl.load = function(context, workspace, collection, documents, options, callback) {
              Severity: Minor
              Found in lib/dispatch/beacon.js - About 45 mins to fix

                Function run has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                  run: function(context, workspace, collection, documents, options, callback) {
                Severity: Minor
                Found in lib/dispatch/beacon.js - About 45 mins to fix

                  Function verify has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  etl.verify = function(context, workspace, collection, documents, callback) {
                  Severity: Minor
                  Found in lib/dispatch/beacon.js - About 35 mins to fix

                    Function run has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                      run: function(context, workspace, collection, documents, options, callback) {

    if (typeof options === 'function') {
      callback = options;
      options = {};
                    Severity: Minor
                    Found in lib/dispatch/beacon.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                              return router.responseError(500, new router.ErrorTemplate('Failed to route action [' + 'insert' + ']: ' + (typeof(err) === 'object' ? err.message : err)), req, res);
                    Severity: Minor
                    Found in lib/dispatch/beacon.js and 1 other location - About 45 mins to fix
                    lib/dispatch/query.js on lines 929..929

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 50.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status