Sign upLogin

joola/joola

View on GitHub
Star
lib/dispatch/collections.js

Summary

Maintainability
F
6 days
Test Coverage

Function run has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
Open

  run: function (context, workspace, collection, document, callback) {
    callback = callback || function () {
    };

    if (context.user.workspace !== workspace && context.user.permissions.indexOf('superuser') === -1) {
Severity: Minor
Found in lib/dispatch/collections.js - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File collections.js has 361 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 *  @title joola.collections
 *  @description
 *  joola uses the concept of `collections` to organize documents into logical sections.
 *  [[Collections]] include definitions on metrics, dimensions and other attributes. that instruct joola on how to
Severity: Minor
Found in lib/dispatch/collections.js - About 4 hrs to fix

    Function run has 116 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      run: function (context, workspace, collection, document, callback) {
    callback = callback || function () {
    };

    if (context.user.workspace !== workspace && context.user.permissions.indexOf('superuser') === -1) {
    Severity: Major
    Found in lib/dispatch/collections.js - About 4 hrs to fix

      Function walkObject has 70 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            var walkObject = function (_shadow, obj) {
        try {
          Object.keys(obj).forEach(function (key) {

            var elem = obj[key];
      Severity: Major
      Found in lib/dispatch/collections.js - About 2 hrs to fix

        Function run has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          run: function (context, workspace, collection, callback) {
    callback = callback || function () {
    };

    if (context.user.workspace !== workspace && context.user.permissions.indexOf('superuser') === -1) {
        Severity: Minor
        Found in lib/dispatch/collections.js - About 1 hr to fix

          Function run has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            run: function (context, workspace, callback) {
    callback = callback || function () {
    };

    if (context.user.workspace !== workspace && context.user.permissions.indexOf('superuser') === -1) {
          Severity: Minor
          Found in lib/dispatch/collections.js - About 1 hr to fix

            Function run has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              run: function (context, workspace, id, callback) {
    callback = callback || function () {
    };

    if (context.user.workspace !== workspace && context.user.permissions.indexOf('superuser') === -1) {
            Severity: Minor
            Found in lib/dispatch/collections.js - About 1 hr to fix

              Function run has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                run: function (context, workspace, collection, document, callback) {
              Severity: Minor
              Found in lib/dispatch/collections.js - About 35 mins to fix

                Function run has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                  run: function (context, workspace, collection, payload, callback) {
                Severity: Minor
                Found in lib/dispatch/collections.js - About 35 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  exports.patch = {
  name: "/collections/patch",
  description: "I patch an existing collection",
  inputs: ['workspace', 'collection', 'payload'],
  _outputExample: {},
                  Severity: Major
                  Found in lib/dispatch/collections.js and 1 other location - About 1 day to fix
                  lib/dispatch/canvases.js on lines 250..290

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 315.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                        function lookup(obj, type, lookupValue) {
        var result = [];
        traverse(obj).map(function (x) {

          if (kindof(x) === 'object') {
                  Severity: Major
                  Found in lib/dispatch/collections.js and 1 other location - About 4 hrs to fix
                  lib/dispatch/collections.js on lines 76..88

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 119.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                          function lookup(obj, type, lookupValue) {
          var result = [];
          traverse(obj).map(function (x) {

            if (kindof(x) === 'object') {
                  Severity: Major
                  Found in lib/dispatch/collections.js and 1 other location - About 4 hrs to fix
                  lib/dispatch/collections.js on lines 153..165

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 119.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                              else if (elem !== null && key === 'timestamp') {
              _shadow[key] = joola.common._extend(_shadow[key], {
                key: key,
                //name: key,
                type: 'dimension',
                  Severity: Major
                  Found in lib/dispatch/collections.js and 2 other locations - About 50 mins to fix
                  lib/dispatch/collections.js on lines 682..729
                  lib/dispatch/collections.js on lines 691..729

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 52.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                              if (elem !== null && key === 'lat') {
              _shadow[key] = joola.common._extend(_shadow[key], {
                key: key,
                //name: key,
                type: 'dimension',
                  Severity: Major
                  Found in lib/dispatch/collections.js and 2 other locations - About 50 mins to fix
                  lib/dispatch/collections.js on lines 691..729
                  lib/dispatch/collections.js on lines 711..729

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 52.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                              else if (elem !== null && key === 'lon') {
              _shadow[key] = joola.common._extend(_shadow[key], {
                key: key,
                //name: key,
                type: 'dimension',
                  Severity: Major
                  Found in lib/dispatch/collections.js and 2 other locations - About 50 mins to fix
                  lib/dispatch/collections.js on lines 682..729
                  lib/dispatch/collections.js on lines 711..729

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 52.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status