Sign upLogin

joola/joola

View on GitHub
Star
lib/dispatch/users.js

Summary

Maintainability
D
2 days
Test Coverage

File users.js has 347 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 *  @title joola/lib/dispatch/users
 *  @overview Provides user management functionality across the framework.
 *  @description
 *  The `users` dispatch manages the entire flow relating to users, for example: listing or adding a user.
Severity: Minor
Found in lib/dispatch/users.js - About 4 hrs to fix

    Function run has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      run: function (context, workspace, username, password, callback) {
    callback = callback || function () {
    };

    var err;
    Severity: Minor
    Found in lib/dispatch/users.js - About 1 hr to fix

      Function run has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        run: function (context, workspace, username, payload, callback) {
    callback = callback || function () {
    };

    if (context.user.workspace !== workspace && context.user.permissions.indexOf('superuser') === -1) {
      Severity: Minor
      Found in lib/dispatch/users.js - About 1 hr to fix

        Function run has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          run: function (context, workspace, user, callback) {
    callback = callback || function () {
    };

    var err;
        Severity: Minor
        Found in lib/dispatch/users.js - About 1 hr to fix

          Function run has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            run: function (context, workspace, username, payload, callback) {
          Severity: Minor
          Found in lib/dispatch/users.js - About 35 mins to fix

            Function run has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

              run: function (context, workspace, username, password, callback) {
            Severity: Minor
            Found in lib/dispatch/users.js - About 35 mins to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  if (context.user.workspace !== workspace && context.user.permissions.indexOf('superuser') === -1) {
      err = new Error('Forbidden');
      err.code = 403;
      return callback(err);
    }
              Severity: Major
              Found in lib/dispatch/users.js and 1 other location - About 1 hr to fix
              lib/dispatch/users.js on lines 447..451

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 74.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  if (context.user.workspace !== workspace && context.user.permissions.indexOf('superuser') === -1) {
      err = new Error('Forbidden');
      err.code = 403;
      return callback(err);
    }
              Severity: Major
              Found in lib/dispatch/users.js and 1 other location - About 1 hr to fix
              lib/dispatch/users.js on lines 219..223

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 74.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                    if (user.permissions && user.permissions.indexOf('superuser') > -1) {
        err = new Error('Forbidden');
        err.code = 403;
        return callback(err);
      }
              Severity: Major
              Found in lib/dispatch/users.js and 1 other location - About 1 hr to fix
              lib/dispatch/users.js on lines 318..322

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 62.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                      if (user.permissions && user.permissions.indexOf('superuser') > -1) {
          err = new Error('Forbidden');
          err.code = 403;
          return callback(err);
        }
              Severity: Major
              Found in lib/dispatch/users.js and 1 other location - About 1 hr to fix
              lib/dispatch/users.js on lines 229..233

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 62.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      joola.config.set('workspaces:' + workspace + ':users:' + user.username, user, function (err) {
          /* istanbul ignore if */
          if (err)
            return callback(err);
              Severity: Major
              Found in lib/dispatch/users.js and 1 other location - About 1 hr to fix
              lib/dispatch/canvases.js on lines 212..218

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 60.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status