Sign upLogin

joola/joola

View on GitHub
Star
lib/webserver/routes/index.js

Summary

Maintainability
C
1 day
Test Coverage

Function router has 72 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.router = function(req, res, next) {
  //check the request should be terminated, signaled by prior middleware
  /* istanbul ignore if */
  if (req.terminate)
    return res.end();
Severity: Major
Found in lib/webserver/routes/index.js - About 2 hrs to fix

    Function setup has 63 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    exports.setup = function(app) {
  //main entry point

  app.get('/ip', function(req, res) {
    res.setHeader('Content-Type', 'application/javascript');
    Severity: Major
    Found in lib/webserver/routes/index.js - About 2 hrs to fix

      Function responseSuccess has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      exports.responseSuccess = function(data, headers, req, res) {
  var meta = {};

  //var realtime = data ? data.realtime : false;
  if (req.timestamps.start) {
      Severity: Minor
      Found in lib/webserver/routes/index.js - About 1 hr to fix

        Function responseError has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        exports.responseError = function(code, err, req, res) {
  joola.logger.debug(err, 'Error while processing route [' + req.url + ']: ' + (typeof(err) === 'object' ? err.message : err));

  if (err.stack)
    joola.logger.trace(err.stack);
        Severity: Minor
        Found in lib/webserver/routes/index.js - About 1 hr to fix

          Function responseSuccess has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

          exports.responseSuccess = function(data, headers, req, res) {
  var meta = {};

  //var realtime = data ? data.realtime : false;
  if (req.timestamps.start) {
          Severity: Minor
          Found in lib/webserver/routes/index.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function responseError has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

          exports.responseError = function(code, err, req, res) {
  joola.logger.debug(err, 'Error while processing route [' + req.url + ']: ' + (typeof(err) === 'object' ? err.message : err));

  if (err.stack)
    joola.logger.trace(err.stack);
          Severity: Minor
          Found in lib/webserver/routes/index.js - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this function.
          Open

                return localRoute(req, res);
          Severity: Major
          Found in lib/webserver/routes/index.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return dispatchRoute(req, res);
            Severity: Major
            Found in lib/webserver/routes/index.js - About 30 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                    Object.keys(req.parsed).forEach(function(key) {
        args.push(req.parsed[key]);
      });
              Severity: Minor
              Found in lib/webserver/routes/index.js and 1 other location - About 35 mins to fix
              lib/dispatch/index.js on lines 426..428

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 47.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status