Sign upLogin

joshminnie/hubtrics

View on GitHub
Star

Showing 4 of 14 total issues

Method generate has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

      def generate
        puts Paint["Grace period: #{grace_period} days", :blue]

        branches = client.branches(repository, protected: false)
Severity: Minor
Found in lib/hubtrics/reports/branches_without_pulls_report.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method generate has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def generate
        puts Paint["Grace period: #{grace_period} days", :blue]

        branches = client.branches(repository, protected: false)
Severity: Minor
Found in lib/hubtrics/reports/branches_without_pulls_report.rb - About 1 hr to fix

    Method parse has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def parse(args)
      parser = OptionParser.new do |opts|
        opts.banner = banner
        opts.program_name = program_name if program_name
    Severity: Minor
    Found in lib/hubtrics/parser.rb - About 1 hr to fix

      Method ignore_branch? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def ignore_branch?(branch)
        ignored_branches = [config.dig('branches', 'protected'), config.dig('branches', 'exclude')].flatten.compact

        if branch.protected? ||
           branch.last_commit > (Date.today - grace_period).to_time.utc ||
      Severity: Minor
      Found in lib/hubtrics/reports/branches_without_pulls_report.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language