Sign upLogin

joyent/node

View on GitHub
Star
deps/npm/lib/adduser.js

Summary

Maintainability
A
3 hrs
Test Coverage

Function save has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function save (c, u, cb) {
  npm.spinner.start()

  // save existing configs, but yank off for this PUT
  var uri   = npm.config.get("registry")
Severity: Minor
Found in deps/npm/lib/adduser.js - About 1 hr to fix

    Function readPassword has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function readPassword (c, u, cb) {
  var v = userValidate.pw

  var prompt
  if (c.p && !c.changed) {
    Severity: Minor
    Found in deps/npm/lib/adduser.js - About 1 hr to fix

      Function adduser has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      function adduser (args, cb) {
  npm.spinner.stop()
  if (!crypto) return cb(new Error(
    "You must compile node with ssl support to use the adduser feature"))
      Severity: Minor
      Found in deps/npm/lib/adduser.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function save has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      function save (c, u, cb) {
  npm.spinner.start()

  // save existing configs, but yank off for this PUT
  var uri   = npm.config.get("registry")
      Severity: Minor
      Found in deps/npm/lib/adduser.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status