joyent/node

Function addTmpTarball has 40 lines of code (exceeds 25 allowed). Consider refactoring.

Open

function addTmpTarball (tgz, pkgData, shasum, cb) {
  assert(typeof cb === "function", "must have callback function")
  assert(shasum, "must have shasum by now")

  cb = inflight("addTmpTarball:" + tgz, cb)

Function addPlacedTarball_ has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

function addPlacedTarball_ (p, pkgData, uid, gid, resolvedSum, cb) {

Avoid too many return statements within this function.

Open

          return cb(new Error("Invalid Package: expected " +
                              pkgData.name + "@" + pkgData.version +
                              " but found " + data.name + "@" + data.version))

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if (!data.version) {
          return cb(new Error("No version provided"))
        }
        else if (pkgData.version && data.version !== pkgData.version) {
          return cb(new Error("Invalid Package: expected " +

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if (!data.name) {
          return cb(new Error("No name provided"))
        }
        else if (pkgData.name && data.name !== pkgData.name) {
          return cb(new Error("Invalid Package: expected " + pkgData.name +

• Read up
  Read up