Sign upLogin

joyent/node

View on GitHub
Star
deps/npm/lib/cache/add-remote-tarball.js

Summary

Maintainability
A
3 hrs
Test Coverage

Function fetchAndShaCheck has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function fetchAndShaCheck (u, tmp, shasum, auth, cb) {
  npm.registry.fetch(u, { auth : auth }, function (er, response) {
    if (er) {
      log.error("fetch failed", u)
      return cb(er, response)
Severity: Minor
Found in deps/npm/lib/cache/add-remote-tarball.js - About 1 hr to fix

    Function addRemoteTarball has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    function addRemoteTarball (u, pkgData, shasum, auth, cb_) {
    Severity: Minor
    Found in deps/npm/lib/cache/add-remote-tarball.js - About 35 mins to fix

      Function addRemoteTarball_ has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      function addRemoteTarball_ (u, tmp, shasum, auth, cb) {
      Severity: Minor
      Found in deps/npm/lib/cache/add-remote-tarball.js - About 35 mins to fix

        Function fetchAndShaCheck has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        function fetchAndShaCheck (u, tmp, shasum, auth, cb) {
        Severity: Minor
        Found in deps/npm/lib/cache/add-remote-tarball.js - About 35 mins to fix

          Function addRemoteTarball has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          function addRemoteTarball (u, pkgData, shasum, auth, cb_) {
  assert(typeof u === "string", "must have module URL")
  assert(typeof cb_ === "function", "must have callback")

  function cb (er, data) {
          Severity: Minor
          Found in deps/npm/lib/cache/add-remote-tarball.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status