Sign upLogin

joyent/node

View on GitHub
Star
deps/npm/lib/dedupe.js

Summary

Maintainability
D
1 day
Test Coverage

Function dedupe_ has 101 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function dedupe_ (dir, filter, unavoidable, dryrun, silent, cb) {
  readInstalled(path.resolve(dir), {}, null, function (er, data, counter) {
    if (er) {
      return cb(er)
    }
Severity: Major
Found in deps/npm/lib/dedupe.js - About 4 hrs to fix

    File dedupe.js has 289 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    // traverse the node_modules/package.json tree
// looking for duplicates.  If any duplicates are found,
// then move them up to the highest level necessary
// in order to make them no longer duplicated.
//
    Severity: Minor
    Found in deps/npm/lib/dedupe.js - About 2 hrs to fix

      Function readInstalled has 68 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function readInstalled (dir, counter, parent, cb) {
  var pkg, children, realpath

  fs.realpath(dir, function (er, rp) {
    realpath = rp
      Severity: Major
      Found in deps/npm/lib/dedupe.js - About 2 hrs to fix

        Function installAndRetest has 39 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function installAndRetest (set, filter, dir, unavoidable, silent, cb) {
  //return cb(null, set)
  var remove = []

  asyncMap(set, function (item, cb) {
        Severity: Minor
        Found in deps/npm/lib/dedupe.js - About 1 hr to fix

          Function findVersions has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function findVersions (npm, summary, cb) {
  // now, for each item in the summary, try to find the maximum version
  // that will satisfy all the ranges.  next step is to install it at
  // the specified location.
  asyncMap(summary, function (item, cb) {
          Severity: Minor
          Found in deps/npm/lib/dedupe.js - About 1 hr to fix

            Function installAndRetest has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            function installAndRetest (set, filter, dir, unavoidable, silent, cb) {
            Severity: Minor
            Found in deps/npm/lib/dedupe.js - About 45 mins to fix

              Function dedupe_ has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              function dedupe_ (dir, filter, unavoidable, dryrun, silent, cb) {
              Severity: Minor
              Found in deps/npm/lib/dedupe.js - About 45 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    mapToRegistry(name, npm.config, function (er, uri, auth) {
      if (er) return cb(er)

      npm.registry.get(uri, { auth : auth }, next)
    })
                Severity: Major
                Found in deps/npm/lib/dedupe.js and 1 other location - About 1 hr to fix
                deps/npm/lib/owner.js on lines 179..183

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 55.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status