Sign upLogin

joyent/node

View on GitHub
Star
deps/npm/lib/run-script.js

Summary

Maintainability
C
1 day
Test Coverage

Function run has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

function run (pkg, wd, cmd, args, cb) {
  if (!pkg.scripts) pkg.scripts = {}

  var cmds
  if (cmd === "restart" && !pkg.scripts.restart) {
Severity: Minor
Found in deps/npm/lib/run-script.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function list has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function list(cb) {
  var json = path.join(npm.localPrefix, "package.json")
  var cmdList = [ "publish", "install", "uninstall"
                , "test", "stop", "start", "restart"
                ].reduce(function (l, p) {
Severity: Minor
Found in deps/npm/lib/run-script.js - About 1 hr to fix

    Function run has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function run (pkg, wd, cmd, args, cb) {
  if (!pkg.scripts) pkg.scripts = {}

  var cmds
  if (cmd === "restart" && !pkg.scripts.restart) {
    Severity: Minor
    Found in deps/npm/lib/run-script.js - About 1 hr to fix

      Function completion has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      runScript.completion = function (opts, cb) {

  // see if there's already a package specified.
  var argv = opts.conf.argv.remain
      Severity: Minor
      Found in deps/npm/lib/run-script.js - About 1 hr to fix

        Function run has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        function run (pkg, wd, cmd, args, cb) {
        Severity: Minor
        Found in deps/npm/lib/run-script.js - About 35 mins to fix

          Avoid too many return statements within this function.
          Open

              return cb(null, allScripts)
          Severity: Major
          Found in deps/npm/lib/run-script.js - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                scripts.forEach(function(script) {
      console.log(prefix + script + s + d.scripts[script])
    })
            Severity: Minor
            Found in deps/npm/lib/run-script.js and 1 other location - About 40 mins to fix
            deps/npm/lib/run-script.js on lines 110..112

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 48.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                runScripts.forEach(function(script) {
      console.log(prefix + script + s + d.scripts[script])
    })
            Severity: Minor
            Found in deps/npm/lib/run-script.js and 1 other location - About 40 mins to fix
            deps/npm/lib/run-script.js on lines 101..103

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 48.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status