Sign upLogin

joyent/node

View on GitHub
Star

Showing 1,896 of 2,859 total issues

Consider simplifying this complex logical expression.
Open

      if (!curr || dFromUrl && cFromUrl && d._from !== curr.from
          || d.version !== curr.version
          || d.version !== l.version) {
        if (parsed.type === 'local') return updateLocalDeps(l.version)
Severity: Major
Found in deps/npm/lib/outdated.js - About 40 mins to fix

    Consider simplifying this complex logical expression.
    Open

          if (!er &&
          data &&
          !context.explicit &&
          context.family[data.name] === data.version &&
          !npm.config.get("force") &&
    Severity: Major
    Found in deps/npm/lib/install.js - About 40 mins to fix

      Consider simplifying this complex logical expression.
      Open

            if (token.previous and token.previous.type == Type.WHITESPACE and
          not token.previous.IsFirstInLine() and
          not (last_non_space_token and last_non_space_token.line_number ==
                   token.line_number and
               last_non_space_token.type == Type.SEMICOLON)):
      Severity: Major
      Found in tools/closure_linter/closure_linter/ecmalintrules.py - About 40 mins to fix

        Consider simplifying this complex logical expression.
        Open

              if (not first_in_line and token.previous.type == Type.WHITESPACE and
          last_non_space_token and
          last_non_space_token.type in Type.EXPRESSION_ENDER_TYPES):
        self._HandleError(errors.EXTRA_SPACE, 'Extra space before "["',
            token.previous, Position.All(token.previous.string))
        Severity: Major
        Found in tools/closure_linter/closure_linter/ecmalintrules.py - About 40 mins to fix

          Consider simplifying this complex logical expression.
          Open

                if state.GetFunction().is_interface:
        if token.previous and token.previous.type == Type.PARAMETERS:
          self._HandleError(errors.INTERFACE_CONSTRUCTOR_CANNOT_HAVE_PARAMS,
              'Interface constructor cannot have parameters',
              token.previous)
          Severity: Major
          Found in tools/closure_linter/closure_linter/ecmalintrules.py - About 40 mins to fix

            Consider simplifying this complex logical expression.
            Open

                    if (flag.flag_type not in ('suppress', 'enum') and
            (flag.type == None or flag.type == '' or flag.type.isspace())):
          self._HandleError(errors.MISSING_JSDOC_TAG_TYPE,
                            'Missing type in %s tag' % token.string, token)
            Severity: Major
            Found in tools/closure_linter/closure_linter/javascriptlintrules.py - About 40 mins to fix

              Consider simplifying this complex logical expression.
              Open

                      if (function.has_this and function.doc and
            not function.doc.HasFlag('this') and
            not function.is_constructor and
            not function.is_interface and
            '.prototype.' not in function.name):
              Severity: Major
              Found in tools/closure_linter/closure_linter/javascriptlintrules.py - About 40 mins to fix

                Consider simplifying this complex logical expression.
                Open

                      if (FLAGS.strict and not self._is_html and state.InTopLevel() and
          not state.InBlock()):

        # Check if we're in a fileoverview or constructor JsDoc.
        doc_comment = state.GetDocComment()
                Severity: Major
                Found in tools/closure_linter/closure_linter/javascriptlintrules.py - About 40 mins to fix

                  Consider simplifying this complex logical expression.
                  Open

                    if line and line[-1].isspace():
    error(filename, linenum, 'whitespace/end_of_line', 4,
          'Line ends in whitespace.  Consider deleting these extra spaces.')
  # There are certain situations we allow one space, notably for labels
  elif ((initial_spaces == 1 or initial_spaces == 3) and
                  Severity: Major
                  Found in tools/cpplint.py - About 40 mins to fix

                    Function start has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    exports.start = function(prompt, source, eval_, useGlobal, ignoreUndefined) {
                    Severity: Minor
                    Found in lib/repl.js - About 35 mins to fix

                      Function REPLServer has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                      function REPLServer(prompt, stream, eval_, useGlobal, ignoreUndefined) {
                      Severity: Minor
                      Found in lib/repl.js - About 35 mins to fix

                        Function pbkdf2Sync has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                        exports.pbkdf2Sync = function(password, salt, iterations, keylen, digest) {
                        Severity: Minor
                        Found in lib/crypto.js - About 35 mins to fix

                          Function readableAddChunk has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                          function readableAddChunk(stream, state, chunk, encoding, addToFront) {
                          Severity: Minor
                          Found in lib/_stream_readable.js - About 35 mins to fix

                            Function _listen2 has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                            Server.prototype._listen2 = function(address, port, addressType, backlog, fd) {
                            Severity: Minor
                            Found in lib/net.js - About 35 mins to fix

                              Function formatArray has 5 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                              function formatArray(ctx, value, recurseTimes, visibleKeys, keys) {
                              Severity: Minor
                              Found in lib/util.js - About 35 mins to fix

                                Function afterConnect has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                function afterConnect(status, handle, req, readable, writable) {
                                Severity: Minor
                                Found in lib/net.js - About 35 mins to fix

                                  Function fail has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                  Open

                                  function fail(actual, expected, message, operator, stackStartFunction) {
                                  Severity: Minor
                                  Found in lib/assert.js - About 35 mins to fix

                                    Function readSync has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                    Open

                                    fs.readSync = function(fd, buffer, offset, length, position) {
                                    Severity: Minor
                                    Found in lib/fs.js - About 35 mins to fix

                                      Function SecurePair has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                      Open

                                      function SecurePair(context, isServer, requestCert, rejectUnauthorized,
                    options) {
                                      Severity: Minor
                                      Found in lib/_tls_legacy.js - About 35 mins to fix

                                        Function writeSync has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                        Open

                                        fs.writeSync = function(fd, buffer, offset, length, position) {
                                        Severity: Minor
                                        Found in lib/fs.js - About 35 mins to fix
                                          Severity
                                          Category
                                          Status
                                          Source
                                          Language