Showing 2,859 of 2,859 total issues

Function stepCommandToJSONRequest_ has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

DebugRequest.prototype.stepCommandToJSONRequest_ = function(args, type) {
  // Requesting a step is through the continue command with additional
  // arguments.
  var request = this.createRequest('continue');
  request.arguments = {};
Severity: Minor
Found in deps/v8/src/d8.js - About 1 hr to fix

    Function end has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    OutgoingMessage.prototype.end = function(data, encoding, callback) {
      if (util.isFunction(data)) {
        callback = data;
        data = null;
      } else if (util.isFunction(encoding)) {
    Severity: Minor
    Found in lib/_http_outgoing.js - About 1 hr to fix

      Function bnpDivRemTo has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function bnpDivRemTo(m,q,r) {
        var pm = m.abs();
        if(pm.t <= 0) return;
        var pt = this.abs();
        if(pt.t < pm.t) {
      Severity: Minor
      Found in deps/v8/benchmarks/crypto.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def IsFlaky(o):
            return (PASS in o) and (FAIL in o) and (not CRASH in o) and (not OKAY in o)
        Severity: Major
        Found in tools/test.py and 1 other location - About 1 hr to fix
        deps/v8/tools/testrunner/local/statusfile.py on lines 77..79

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            try:
              pf = file(self.pidfile, 'r')
              pid = int(pf.read().strip())
              pf.close()
            except IOError:
        Severity: Major
        Found in deps/v8/tools/testrunner/server/daemon.py and 1 other location - About 1 hr to fix
        deps/v8/tools/testrunner/server/daemon.py on lines 86..91

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            try:
              pf = file(self.pidfile, 'r')
              pid = int(pf.read().strip())
              pf.close()
            except IOError:
        Severity: Major
        Found in deps/v8/tools/testrunner/server/daemon.py and 1 other location - About 1 hr to fix
        deps/v8/tools/testrunner/server/daemon.py on lines 107..112

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          if parallel:
            LoadTargetBuildFilesParallel(build_files, data, aux_data,
                                         variables, includes, depth, check,
                                         generator_input_info)
          else:
        Severity: Major
        Found in tools/gyp/pylib/gyp/input.py and 1 other location - About 1 hr to fix
        tools/gyp/pylib/gyp/input.py on lines 434..442

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            if cxx_sources and (cflags or cflags_cxx):
              flags = []
              flags.extend(cflags)
              flags.extend(cflags_cxx)
              SetFilesProperty(output, cxx_sources, 'COMPILE_FLAGS', flags, ' ')
        Severity: Major
        Found in tools/gyp/pylib/gyp/generator/cmake.py and 1 other location - About 1 hr to fix
        tools/gyp/pylib/gyp/generator/cmake.py on lines 903..907

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        def IsPassOrFail(outcomes):
          return ((PASS in outcomes) and (FAIL in outcomes) and
                  (not CRASH in outcomes) and (not OKAY in outcomes))
        Severity: Major
        Found in deps/v8/tools/testrunner/local/statusfile.py and 1 other location - About 1 hr to fix
        tools/test.py on lines 1304..1305

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          if load_dependencies:
            for dependency in dependencies:
              try:
                LoadTargetBuildFile(dependency, data, aux_data, variables,
                                    includes, depth, check, load_dependencies)
        Severity: Major
        Found in tools/gyp/pylib/gyp/input.py and 1 other location - About 1 hr to fix
        tools/gyp/pylib/gyp/input.py on lines 2684..2695

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            if c_sources and (cflags or cflags_c):
              flags = []
              flags.extend(cflags)
              flags.extend(cflags_c)
              SetFilesProperty(output, c_sources, 'COMPILE_FLAGS', flags, ' ')
        Severity: Major
        Found in tools/gyp/pylib/gyp/generator/cmake.py and 1 other location - About 1 hr to fix
        tools/gyp/pylib/gyp/generator/cmake.py on lines 909..913

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function lookup has 45 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        exports.lookup = function lookup(hostname, options, callback) {
          var hints = 0;
          var family = -1;
        
          // Parse arguments
        Severity: Minor
        Found in lib/dns.js - About 1 hr to fix

          Function wrap has 45 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          Readable.prototype.wrap = function(stream) {
            var state = this._readableState;
            var paused = false;
          
            var self = this;
          Severity: Minor
          Found in lib/_stream_readable.js - About 1 hr to fix

            Function cb has 45 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              function cb (er, data) {
                var s = npm.config.get('save')
                  , d = npm.config.get('save-dev')
                  , o = npm.config.get('save-optional')
                if (er || !(s || d || o)) return cb_(er, data)
            Severity: Minor
            Found in deps/npm/lib/uninstall.js - About 1 hr to fix

              Function edit has 45 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function edit (cb) {
                var e = npm.config.get("editor")
                  , which = npm.config.get("global") ? "global" : "user"
                  , f = npm.config.get(which + "config")
                if (!e) return cb(new Error("No EDITOR config or environ set."))
              Severity: Minor
              Found in deps/npm/lib/config.js - About 1 hr to fix

                Function GetLdflags has 45 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  def GetLdflags(self, config, gyp_to_build_path, expand_special,
                                 manifest_base_name, output_name, is_executable, build_dir):
                    """Returns the flags that need to be added to link commands, and the
                    manifest files."""
                    config = self._TargetConfig(config)
                Severity: Minor
                Found in tools/gyp/pylib/gyp/msvs_emulation.py - About 1 hr to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      if (this.toggledisplay.next_mode == "plot") {
                        this.toggledisplay.next_mode = "prof";
                        this.plot.style.display = "block";
                        this.prof.style.display = "none";
                        this.toggledisplay.innerHTML = "Show profile";
                  Severity: Major
                  Found in deps/v8/tools/profviz/profviz.js and 1 other location - About 1 hr to fix
                  deps/v8/tools/profviz/profviz.js on lines 153..158

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 71.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      } else {
                        this.toggledisplay.next_mode = "plot";
                        this.plot.style.display = "none";
                        this.prof.style.display = "block";
                        this.toggledisplay.innerHTML = "Show plot";
                  Severity: Major
                  Found in deps/v8/tools/profviz/profviz.js and 1 other location - About 1 hr to fix
                  deps/v8/tools/profviz/profviz.js on lines 148..153

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 71.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Function spawnSync has 44 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  function spawnSync(/*file, args, options*/) {
                    var opts = normalizeSpawnArguments.apply(null, arguments);
                  
                    var options = opts.options;
                  
                  
                  Severity: Minor
                  Found in lib/child_process.js - About 1 hr to fix

                    Function setupMaster has 44 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      cluster.setupMaster = function(options) {
                        var settings = {
                          args: process.argv.slice(2),
                          exec: process.argv[1],
                          execArgv: process.execArgv,
                    Severity: Minor
                    Found in lib/cluster.js - About 1 hr to fix
                      Severity
                      Category
                      Status
                      Source
                      Language