Showing 1,370 of 2,859 total issues

Function CheckIncludeLine has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
Open

def CheckIncludeLine(filename, clean_lines, linenum, include_state, error):
  """Check rules that are applicable to #include lines.

  Strings on #include lines are NOT removed from elided line, to make
  certain tasks easier. However, to prevent false positives, checks
Severity: Minor
Found in tools/cpplint.py - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function CleanupVcproj has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
Open

def CleanupVcproj(node):
  """For each sub node, we call recursively this function."""
  for sub_node in node.childNodes:
    AbsoluteNode(sub_node)
    CleanupVcproj(sub_node)
Severity: Minor
Found in tools/gyp/tools/pretty_vcproj.py - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _TalkToPeer has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
Open

  def _TalkToPeer(self, peer):
    sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
    sock.settimeout(self.context.timeout + 10)
    code = sock.connect_ex((peer.address, constants.PEER_PORT))
    if code == 0:
Severity: Minor
Found in deps/v8/tools/testrunner/network/network_execution.py - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File v.js has 354 lines of code (exceeds 250 allowed). Consider refactoring.
Open

// Copyright 2011 the V8 project authors. All rights reserved.
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are
// met:
//
Severity: Minor
Found in deps/v8/benchmarks/spinning-balls/v.js - About 4 hrs to fix

    File sodium.js has 352 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    // Copyright 2013 the V8 project authors. All rights reserved.
    // Redistribution and use in source and binary forms, with or without
    // modification, are permitted provided that the following conditions are
    // met:
    //
    Severity: Minor
    Found in deps/v8/tools/sodium/sodium.js - About 4 hrs to fix

      File profile.js has 351 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      // Copyright 2009 the V8 project authors. All rights reserved.
      // Redistribution and use in source and binary forms, with or without
      // modification, are permitted provided that the following conditions are
      // met:
      //
      Severity: Minor
      Found in deps/v8/tools/profile.js - About 4 hrs to fix

        Function removeList has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
        Open

        def removeList(count=0):
            # don't allow "keep" items to creep in here.
            global remove
            remove = remove - keep
            if(count > 10):
        Severity: Minor
        Found in tools/icu/icutrim.py - About 4 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function _GetAllowableIndentations has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
        Open

          def _GetAllowableIndentations(self):
            """Computes the set of allowable indentations.
        
            Returns:
              The set of allowable indentations, given the current stack.
        Severity: Minor
        Found in tools/closure_linter/closure_linter/indentation.py - About 4 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function output_words has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
        Open

          def output_words(self, f, start_address, end_address,
                           highlight_address, desc):
            region = self.reader.FindRegion(highlight_address)
            if region is None:
              f.write("<h3>Address 0x%x not found in the dump.</h3>\n" %
        Severity: Minor
        Found in deps/v8/tools/grokdump.py - About 4 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function Load has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
        Open

          def Load(self, mmap_info, code_map, options):
            # Skip kernel mmaps when requested using the fact that their tid
            # is 0.
            if mmap_info.tid == 0 and not options.kernel:
              return True
        Severity: Minor
        Found in deps/v8/tools/ll_prof.py - About 4 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        NinjaWriter has 34 functions (exceeds 20 allowed). Consider refactoring.
        Open

        class NinjaWriter:
          def __init__(self, qualified_target, target_outputs, base_dir, build_dir,
                       output_file, toplevel_build, output_file_name, flavor,
                       toplevel_dir=None):
            """
        Severity: Minor
        Found in tools/gyp/pylib/gyp/generator/ninja.py - About 4 hrs to fix

          Function setBreakpoint has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
          Open

          Interface.prototype.setBreakpoint = function(script, line,
                                                       condition, silent) {
            if (!this.requireConnection()) return;
          
            var self = this,
          Severity: Minor
          Found in lib/_debugger.js - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function Zlib has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
          Open

          function Zlib(opts, mode) {
            this._opts = opts = opts || {};
            this._chunkSize = opts.chunkSize || exports.Z_DEFAULT_CHUNK;
          
            Transform.call(this, opts);
          Severity: Minor
          Found in lib/zlib.js - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function WriteRules has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
          Open

            def WriteRules(self, rules, extra_sources, extra_outputs,
                           extra_mac_bundle_resources, part_of_all):
              """Write Makefile code for any 'rules' from the gyp input.
          
              extra_sources: a list that will be filled in with newly generated source
          Severity: Minor
          Found in tools/gyp/pylib/gyp/generator/make.py - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function LoadTargetBuildFile has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
          Open

          def LoadTargetBuildFile(build_file_path, data, aux_data, variables, includes,
                                  depth, check, load_dependencies):
            # If depth is set, predefine the DEPTH variable to be a relative path from
            # this build file's directory to the directory identified by depth.
            if depth:
          Severity: Minor
          Found in tools/gyp/pylib/gyp/input.py - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function TakeOverOnlyChild has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
          Open

            def TakeOverOnlyChild(self, recurse=False):
              """If this PBXGroup has only one child and it's also a PBXGroup, take
              it over by making all of its children this object's children.
          
              This function will continue to take over only children when those children
          Severity: Minor
          Found in tools/gyp/pylib/gyp/xcodeproj_file.py - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function FindRuntimeFunctions has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
          Open

          def FindRuntimeFunctions():
            inline_functions = FindInlineRuntimeFunctions()
            functions = []
            expanded_lines = ReadFileAndExpandMacros(FILENAME)
            function = None
          Severity: Minor
          Found in deps/v8/tools/generate-runtime-tests.py - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function ClassifyFunctions has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
          Open

          def ClassifyFunctions(functions):
            # Can be fuzzed with a JavaScript testcase.
            js_fuzzable_functions = []
            # We have enough information to fuzz these, but they need inputs that
            # cannot be created or passed around in JavaScript.
          Severity: Minor
          Found in deps/v8/tools/generate-runtime-tests.py - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          File ecmametadatapass.py has 341 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          #!/usr/bin/env python
          #
          # Copyright 2010 The Closure Linter Authors. All Rights Reserved.
          #
          # Licensed under the Apache License, Version 2.0 (the "License");
          Severity: Minor
          Found in tools/closure_linter/closure_linter/ecmametadatapass.py - About 4 hrs to fix

            File stats-viewer.py has 341 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            #!/usr/bin/env python
            #
            # Copyright 2008 the V8 project authors. All rights reserved.
            # Redistribution and use in source and binary forms, with or without
            # modification, are permitted provided that the following conditions are
            Severity: Minor
            Found in deps/v8/tools/stats-viewer.py - About 4 hrs to fix
              Severity
              Category
              Status
              Source
              Language