Showing 1,657 of 2,859 total issues

Function ProcessContents has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

  def ProcessContents(self, name, contents):
    result = True
    base = basename(name)
    if not base in SourceProcessor.IGNORE_TABS:
      if '\t' in contents:
Severity: Minor
Found in deps/v8/tools/presubmit.py - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function Execute has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

def Execute(arch, mode, args, options, suites, workspace):
  print(">>> Running tests for %s.%s" % (arch, mode))

  shell_dir = options.shell_dir
  if not shell_dir:
Severity: Minor
Found in deps/v8/tools/run-tests.py - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File add-remote-git.js has 368 lines of code (exceeds 250 allowed). Consider refactoring.
Open

var assert = require('assert')
var crypto = require('crypto')
var fs = require('graceful-fs')
var path = require('path')
var url = require('url')
Severity: Minor
Found in deps/npm/lib/cache/add-remote-git.js - About 4 hrs to fix

    File timers.js has 367 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    // Copyright Joyent, Inc. and other Node contributors.
    //
    // Permission is hereby granted, free of charge, to any person obtaining a
    // copy of this software and associated documentation files (the
    // "Software"), to deal in the Software without restriction, including
    Severity: Minor
    Found in lib/timers.js - About 4 hrs to fix

      File indentation.py has 367 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      #!/usr/bin/env python
      #
      # Copyright 2010 The Closure Linter Authors. All Rights Reserved.
      #
      # Licensed under the Apache License, Version 2.0 (the "License");
      Severity: Minor
      Found in tools/closure_linter/closure_linter/indentation.py - About 4 hrs to fix

        File presubmit.py has 367 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        #!/usr/bin/env python
        #
        # Copyright 2012 the V8 project authors. All rights reserved.
        # Redistribution and use in source and binary forms, with or without
        # modification, are permitted provided that the following conditions are
        Severity: Minor
        Found in deps/v8/tools/presubmit.py - About 4 hrs to fix

          Function formatProperty has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
          Open

          function formatProperty(ctx, value, recurseTimes, visibleKeys, key, array) {
            var name, str, desc;
            desc = Object.getOwnPropertyDescriptor(value, key) || { value: value[key] };
            if (desc.get) {
              if (desc.set) {
          Severity: Minor
          Found in lib/util.js - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function listen has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
          Open

          Server.prototype.listen = function() {
            var self = this;
          
            var lastArg = arguments[arguments.length - 1];
            if (util.isFunction(lastArg)) {
          Severity: Minor
          Found in lib/net.js - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function execFile has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
          Open

          exports.execFile = function(file /* args, options, callback */) {
            var args = [], callback;
            var options = {
              encoding: 'utf8',
              timeout: 0,
          Severity: Minor
          Found in lib/child_process.js - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function Buffer has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
          Open

          function Buffer(subject, encoding) {
            if (!util.isBuffer(this))
              return new Buffer(subject, encoding);
          
            if (util.isNumber(subject)) {
          Severity: Minor
          Found in lib/buffer.js - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function realpath has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
          Open

          fs.realpath = function realpath(p, cache, cb) {
            if (!util.isFunction(cb)) {
              cb = maybeCallback(cache);
              cache = null;
            }
          Severity: Minor
          Found in lib/fs.js - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _parseMap has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
          Open

              _parseMap: function(map, lineNumber, columnNumber)
              {
                  var sourceIndex = 0;
                  var sourceLineNumber = 0;
                  var sourceColumnNumber = 0;
          Severity: Minor
          Found in deps/v8/tools/SourceMap.js - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function ProcessToolsetsInDict has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
          Open

          def ProcessToolsetsInDict(data):
            if 'targets' in data:
              target_list = data['targets']
              new_target_list = []
              for target in target_list:
          Severity: Minor
          Found in tools/gyp/pylib/gyp/input.py - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function SetUpConfigurations has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
          Open

          def SetUpConfigurations(target, target_dict):
            # key_suffixes is a list of key suffixes that might appear on key names.
            # These suffixes are handled in conditional evaluations (for =, +, and ?)
            # and rules/exclude processing (for ! and /).  Keys with these suffixes
            # should be treated the same as keys without.
          Severity: Minor
          Found in tools/gyp/pylib/gyp/input.py - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function VerifyNoGYPFileCircularDependencies has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
          Open

          def VerifyNoGYPFileCircularDependencies(targets):
            # Create a DependencyGraphNode for each gyp file containing a target.  Put
            # it into a dict for easy access.
            dependency_nodes = {}
            for target in targets.iterkeys():
          Severity: Minor
          Found in tools/gyp/pylib/gyp/input.py - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function ShardTargets has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
          Open

          def ShardTargets(target_list, target_dicts):
            """Shard some targets apart to work around the linkers limits.
          
            Arguments:
              target_list: List of target pairs: 'base/base.gyp:base'.
          Severity: Minor
          Found in tools/gyp/pylib/gyp/MSVSUtil.py - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function do_GET has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
          Open

            def do_GET(self):
              try:
                parsedurl = urlparse.urlparse(self.path)
                query_components = urlparse.parse_qs(parsedurl.query)
                if parsedurl.path == "/dumps.html":
          Severity: Minor
          Found in deps/v8/tools/grokdump.py - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function connect has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
          Open

          Socket.prototype.connect = function(options, cb) {
            if (this.write !== Socket.prototype.write)
              this.write = Socket.prototype.write;
          
            if (!util.isObject(options)) {
          Severity: Minor
          Found in lib/net.js - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function readableAddChunk has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
          Open

          function readableAddChunk(stream, state, chunk, encoding, addToFront) {
            var er = chunkInvalid(state, chunk);
            if (er) {
              stream.emit('error', er);
            } else if (chunk === null) {
          Severity: Minor
          Found in lib/_stream_readable.js - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function read has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
          Open

          sc_Reader.prototype.read = function() {
              function readList(listBeginType) {
              function matchesPeer(open, close) {
                  return open === 1/*OPEN_PAR*/ && close === 2/*CLOSE_PAR*/
                      || open === 3/*OPEN_BRACE*/ && close === 4/*CLOSE_BRACE*/
          Severity: Minor
          Found in deps/v8/benchmarks/earley-boyer.js - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language