Sign upLogin

joyent/node

View on GitHub
Star
lib/_stream_writable.js

Summary

Maintainability
D
1 day
Test Coverage

File _stream_writable.js has 329 lines of code (exceeds 250 allowed). Consider refactoring.
Open

// Copyright Joyent, Inc. and other Node contributors.
//
// Permission is hereby granted, free of charge, to any person obtaining a
// copy of this software and associated documentation files (the
// "Software"), to deal in the Software without restriction, including
Severity: Minor
Found in lib/_stream_writable.js - About 3 hrs to fix

    Function clearBuffer has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

    function clearBuffer(stream, state) {
  state.bufferProcessing = true;
  var entry = state.bufferedRequest;

  if (stream._writev && entry && entry.next) {
    Severity: Minor
    Found in lib/_stream_writable.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function clearBuffer has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function clearBuffer(stream, state) {
  state.bufferProcessing = true;
  var entry = state.bufferedRequest;

  if (stream._writev && entry && entry.next) {
    Severity: Minor
    Found in lib/_stream_writable.js - About 1 hr to fix

      Function WritableState has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function WritableState(options, stream) {
  options = options || {};

  // object stream flag to indicate whether or not this stream
  // contains buffers or objects.
      Severity: Minor
      Found in lib/_stream_writable.js - About 1 hr to fix

        Function doWrite has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        function doWrite(stream, state, writev, len, chunk, encoding, cb) {
        Severity: Major
        Found in lib/_stream_writable.js - About 50 mins to fix

          Function writeOrBuffer has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

          function writeOrBuffer(stream, state, chunk, encoding, cb) {
  chunk = decodeChunk(state, chunk, encoding);
  if (util.isBuffer(chunk))
    encoding = 'buffer';
  var len = state.objectMode ? 1 : chunk.length;
          Severity: Minor
          Found in lib/_stream_writable.js - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function onwrite has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

          function onwrite(stream, er) {
  var state = stream._writableState;
  var sync = state.sync;
  var cb = state.writecb;
          Severity: Minor
          Found in lib/_stream_writable.js - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function onwriteError has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          function onwriteError(stream, state, sync, er, cb) {
          Severity: Minor
          Found in lib/_stream_writable.js - About 35 mins to fix

            Function writeOrBuffer has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            function writeOrBuffer(stream, state, chunk, encoding, cb) {
            Severity: Minor
            Found in lib/_stream_writable.js - About 35 mins to fix

              Function write has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

              Writable.prototype.write = function(chunk, encoding, cb) {
  var state = this._writableState;
  var ret = false;

  if (util.isFunction(encoding)) {
              Severity: Minor
              Found in lib/_stream_writable.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                if (!util.isBuffer(chunk) &&
      !util.isString(chunk) &&
      !util.isNullOrUndefined(chunk) &&
      !state.objectMode) {
    var er = new TypeError('Invalid non-string/buffer chunk');
              Severity: Minor
              Found in lib/_stream_writable.js and 1 other location - About 45 mins to fix
              lib/_stream_readable.js on lines 381..386

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 50.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status