Sign upLogin

jproulx/node-custom-error

View on GitHub
Star
error.js

Summary

Maintainability
C
1 day
Test Coverage

Function createError has 101 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function createError (name, parameters, Constructor) {
    if (!name) {
        throw new TypeError('A custom error name is required');
    }
    // Check to make sure we're inheriting from a regular function first
Severity: Major
Found in error.js - About 4 hrs to fix

    Function createError has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

    module.exports = function createError (name, parameters, Constructor) {
    if (!name) {
        throw new TypeError('A custom error name is required');
    }
    // Check to make sure we're inheriting from a regular function first
    Severity: Minor
    Found in error.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function CustomError has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function CustomError (message) {
        // We start by simply creating a new error object, so that we preserve
        // the runtime error logic
        var proxy = new Error(message);
        // We want to call our constructor on the error object itself,
    Severity: Minor
    Found in error.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          if (parameters) {
        Object.keys(parameters).forEach(function (name) {
            proto[name] = {
                'value' : parameters[name],
                'enumerable'   : true,
      Severity: Major
      Found in error.js and 1 other location - About 1 hr to fix
      error.js on lines 32..41

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 65.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          if (parameters) {
        Object.keys(parameters).forEach(function (property) {
            properties[property] = {
                'value'        : parameters[property],
                'enumerable'   : true,
      Severity: Major
      Found in error.js and 1 other location - About 1 hr to fix
      error.js on lines 128..137

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 65.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status