Sign upLogin

jrbeilke/teamsupport

View on GitHub
Star

Showing 3 of 17 total issues

Method initialize has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def initialize(attrs = {})
      # Workaround for dealing with TeamSupport API inconsistently sending ID for objects
      unless attrs[:ID]
        attrs[:ID] = attrs.fetch(:OrganizationID) if attrs[:OrganizationID]
Severity: Minor
Found in lib/teamsupport/identity.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method perform_request_with_objects_from_collection has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

      def perform_request_with_objects_from_collection(request_method, path, options, klass, collection_name) # rubocop:disable Metrics/ParameterLists
Severity: Minor
Found in lib/teamsupport/rest/utils.rb - About 35 mins to fix

    Method perform_request_with_object_from_collection has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def perform_request_with_object_from_collection(request_method, path, options, klass, collection_name) # rubocop:disable Metrics/ParameterLists
    Severity: Minor
    Found in lib/teamsupport/rest/utils.rb - About 35 mins to fix
      Severity
      Category
      Status
      Source
      Language