Sign upLogin

json-roa/json-roa_ruby-client

View on GitHub
Star

Showing 5 of 5 total issues

Method call has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    def call(env)
      @app.call(env).on_complete do |env|
        env.class.class_eval do |klass|
          attr_accessor :json_roa_data
        end
Severity: Minor
Found in lib/json_roa/client.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method each has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

      def each(&_block)
        loop do

          relations = collection_data['relations'] rescue []
Severity: Minor
Found in lib/json_roa/client/collection.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method call has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def call(env)
      @app.call(env).on_complete do |env|
        env.class.class_eval do |klass|
          attr_accessor :json_roa_data
        end
Severity: Minor
Found in lib/json_roa/client.rb - About 1 hr to fix

    Method run_request has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def run_request(method, query_parameters, body, headers, &block)
    Severity: Minor
    Found in lib/json_roa/client/relation.rb - About 35 mins to fix

      Method connect has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

            def connect(url, options = {}, &_block)
        options = DEFAULT_OPTIONS.merge(options)
        @conn = Faraday.new(
          url: url,
          headers: { accept: 'application/json-roa+json' }) do |conn|
      Severity: Minor
      Found in lib/json_roa/client.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language