Sign upLogin

json-schema-form/json-schema-form-generator-es6

View on GitHub
Star
src/form-definitions-generator.js

Summary

Maintainability
D
1 day
Test Coverage

formDefinitionsGenerator has 29 functions (exceeds 20 allowed). Consider refactoring.
Open

const formDefinitionsGenerator = {
  generateField(field, definitions){
    "use strict";
    let morpher = _.camelCase('_generate_' + field.type.replace('-', '_') + '_field');
Severity: Minor
Found in src/form-definitions-generator.js - About 3 hrs to fix

    Function generateStandardFormAttributes has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      generateStandardFormAttributes(field, definitions)  {

    let form, formIndex, formProps = [
      'key',
      'condition',
    Severity: Minor
    Found in src/form-definitions-generator.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        generateCheckboxField(field, definitions){
    definitions.schema.properties[field.key]['type'] = 'string';
    definitions.schema.properties[field.key]['enum'] = field.enum;
    return definitions;
  },
      Severity: Major
      Found in src/form-definitions-generator.js and 1 other location - About 1 hr to fix
      src/form-definitions-generator.js on lines 95..99

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 71.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        generateSelectField(field, definitions){
    definitions.schema.properties[field.key]['type'] = 'string';
    definitions.schema.properties[field.key]['enum'] = field.enum;
    return definitions;
  },
      Severity: Major
      Found in src/form-definitions-generator.js and 1 other location - About 1 hr to fix
      src/form-definitions-generator.js on lines 100..104

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 71.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

        generateDateField(field, definitions){
    definitions.schema.properties[field.key]['type'] = 'string';
    definitions.schema.properties[field.key]['format'] = 'date';
    return definitions;
  },
      Severity: Major
      Found in src/form-definitions-generator.js and 3 other locations - About 1 hr to fix
      src/form-definitions-generator.js on lines 90..94
      src/form-definitions-generator.js on lines 110..114
      src/form-definitions-generator.js on lines 115..119

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 67.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

        generateEmailField(field, definitions){
    definitions.schema.properties[field.key]['type'] = 'string';
    definitions.schema.properties[field.key]['format'] = 'email';
    return definitions;
  },
      Severity: Major
      Found in src/form-definitions-generator.js and 3 other locations - About 1 hr to fix
      src/form-definitions-generator.js on lines 105..109
      src/form-definitions-generator.js on lines 110..114
      src/form-definitions-generator.js on lines 115..119

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 67.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

        generateTimeField(field, definitions){
    definitions.schema.properties[field.key]['type'] = 'string';
    definitions.schema.properties[field.key]['format'] = 'time';
    return definitions;
  },
      Severity: Major
      Found in src/form-definitions-generator.js and 3 other locations - About 1 hr to fix
      src/form-definitions-generator.js on lines 90..94
      src/form-definitions-generator.js on lines 105..109
      src/form-definitions-generator.js on lines 115..119

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 67.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

        generateDateTimeField(field, definitions){
    definitions.schema.properties[field.key]['type'] = 'string';
    definitions.schema.properties[field.key]['format'] = 'date-time';
    return definitions;
  },
      Severity: Major
      Found in src/form-definitions-generator.js and 3 other locations - About 1 hr to fix
      src/form-definitions-generator.js on lines 90..94
      src/form-definitions-generator.js on lines 105..109
      src/form-definitions-generator.js on lines 110..114

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 67.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status