Sign upLogin

jsperf/jsperf.com

View on GitHub
Star
server/web/edit/index.js

Summary

Maintainability
D
2 days
Test Coverage

Function register has 130 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.register = function (server, options, next) {
  const pagesService = server.plugins['services/pages'];

  server.route({
    method: 'GET',
Severity: Major
Found in server/web/edit/index.js - About 5 hrs to fix

    Function handler has 69 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        handler: function (request, reply) {
      const errResp = function (errObj) {
        if (errObj.message) {
          errObj.genError = errObj.message;
        }
    Severity: Major
    Found in server/web/edit/index.js - About 2 hrs to fix

      Function handler has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          handler: function (request, reply) {
      pagesService.getBySlug(request.params.testSlug, request.params.rev)
        .then(function (values) {
          let page = values[0];
          page.test = values[1];
      Severity: Minor
      Found in server/web/edit/index.js - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                  pageWithTests.test.forEach((t, idx) => {
            const missingTitle = t.title === defaults.deleteMe;
            const missingCode = t.code === defaults.deleteMe;

            if (missingTitle && !missingCode) {
        Severity: Major
        Found in server/web/edit/index.js and 1 other location - About 6 hrs to fix
        server/web/home/index.js on lines 79..92

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 162.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

              pagesService.getBySlug(request.params.testSlug, request.params.rev)
        .then(function (values) {
          let page = values[0];
          page.test = values[1];
          page.revision = values[2];
        Severity: Minor
        Found in server/web/edit/index.js and 1 other location - About 40 mins to fix
        server/web/test/index.js on lines 162..186

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status