Sign upLogin

jstacoder/flask-tasks

View on GitHub
Star
flask_tasks/static/js/app/projects.js

Summary

Maintainability
D
2 days
Test Coverage

Function TaskCtrl has 114 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function TaskCtrl(project,task,activeTasks,$routeParams,$route,$location,$window,$interpolate,$scope){
    var self = this,
        projectUrlFunc = $interpolate('/app/project/{{ pid }}'),
        changeFunc = $interpolate('/app/project/{{ pid }}/{{ tid }}');
Severity: Major
Found in flask_tasks/static/js/app/projects.js - About 4 hrs to fix

    File projects.js has 266 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    'use strict';

var app = angular.module('app.projects',[]);

app.factory('projectFactory',projectFactory)
    Severity: Minor
    Found in flask_tasks/static/js/app/projects.js - About 2 hrs to fix

      Function ProjCtrl has 57 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function ProjCtrl(project,$location,$interpolate,sortByPriority,completeTask,$window,$q,$rootScope){
    var self = this,
        urlFunc = $interpolate('/app/project/{{ pid }}/{{ tid }}');

    self.project = project;
      Severity: Major
      Found in flask_tasks/static/js/app/projects.js - About 2 hrs to fix

        Function TaskCtrl has 9 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        function TaskCtrl(project,task,activeTasks,$routeParams,$route,$location,$window,$interpolate,$scope){
        Severity: Major
        Found in flask_tasks/static/js/app/projects.js - About 1 hr to fix

          Function ProjCtrl has 8 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          function ProjCtrl(project,$location,$interpolate,sortByPriority,completeTask,$window,$q,$rootScope){
          Severity: Major
          Found in flask_tasks/static/js/app/projects.js - About 1 hr to fix

            Function TaskCtrl has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            function TaskCtrl(project,task,activeTasks,$routeParams,$route,$location,$window,$interpolate,$scope){
    var self = this,
        projectUrlFunc = $interpolate('/app/project/{{ pid }}'),
        changeFunc = $interpolate('/app/project/{{ pid }}/{{ tid }}');
            Severity: Minor
            Found in flask_tasks/static/js/app/projects.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    angular.forEach(self.project.tasks,function(itm){
            if(!itm.complete){
                active.push(itm);
                if(parseInt(id)==itm.id){
                    idx = active.length-1;
            Severity: Major
            Found in flask_tasks/static/js/app/projects.js and 1 other location - About 2 hrs to fix
            flask_tasks/static/js/app/projects.js on lines 76..83

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 84.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            app.factory('projectFactory',projectFactory)
    .factory('getProject',getProject)
    .factory('getActiveProjects',getActiveProjects)
    .factory('sortByPriority',sortByPriority)
    .factory('completeTask',completeTask)
            Severity: Major
            Found in flask_tasks/static/js/app/projects.js and 1 other location - About 2 hrs to fix
            flask_tasks/static/js/app.js on lines 154..162

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 84.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    angular.forEach(self.project.tasks,function(itm){
            if(!itm.complete){
                active.push(itm);
                if(parseInt(id)==itm.id){
                    idx = active.length-1;
            Severity: Major
            Found in flask_tasks/static/js/app/projects.js and 1 other location - About 2 hrs to fix
            flask_tasks/static/js/app/projects.js on lines 89..96

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 84.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                self.nextTask = function(){
        var rtn = changeFunc({pid:self.project.id,tid:getNextTask(self.tid)});
        return rtn;
    };
            Severity: Major
            Found in flask_tasks/static/js/app/projects.js and 1 other location - About 1 hr to fix
            flask_tasks/static/js/app/projects.js on lines 64..67

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 57.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                self.lastTask = function(){
        var rtn = changeFunc({pid:self.project.id,tid:getLastTask(self.tid)});
        return rtn;
    };
            Severity: Major
            Found in flask_tasks/static/js/app/projects.js and 1 other location - About 1 hr to fix
            flask_tasks/static/js/app/projects.js on lines 68..71

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 57.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status