Sign upLogin

jstotz/jstreams

View on GitHub
Star

Showing 1 of 1 total issue

Method reclaim_abandoned_messages_in_stream has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def reclaim_abandoned_messages_in_stream(stream)
      reclaim_ids = []
      # TODO: pagination & configurable batch size
      read_pending(stream, ABANDONED_MESSAGE_BATCH_SIZE).each do |pe|
        unless pe['consumer'] != consumer_name && abandoned_pending_entry?(pe)
Severity: Minor
Found in lib/jstreams/subscriber.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language