Sign upLogin

juanmard/icestudio

View on GitHub
Star
controllers/design.js

Summary

Maintainability
C
7 hrs
Test Coverage

Function _editModeToggle has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      function _editModeToggle() {
        var block = graph.breadcrumbs[graph.breadcrumbs.length - 1];
        var tmp = false;
        const rw = common.isEditingSubmodule;
        common.isEditingSubmodule = !rw;
Severity: Minor
Found in controllers/design.js - About 1 hr to fix

    Function _breadcrumbsJump has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          function _breadcrumbsJump(selectedItem) {
        if (common.isEditingSubmodule) {
          $log.error('Navigation while editing is not supported!');
          return;
        }
    Severity: Minor
    Found in controllers/design.js - About 1 hr to fix

      Function _navigateProject has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            function _navigateProject(update, prj, submodule, submoduleId, editMode) {
      Severity: Minor
      Found in controllers/design.js - About 35 mins to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                  cells = _.sortBy(cells, function (cell) {
            if (
              cell.get('type') === 'ice.Constant' ||
              cell.get('type') === 'ice.Memory'
            ) {
        Severity: Major
        Found in controllers/design.js and 1 other location - About 2 hrs to fix
        services/project.js on lines 450..457

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 76.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                  cells = _.sortBy(cells, function (cell) {
            if (
              cell.get('type') === 'ice.Input' ||
              cell.get('type') === 'ice.Output'
            ) {
        Severity: Major
        Found in controllers/design.js and 1 other location - About 1 hr to fix
        services/project.js on lines 460..467

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 74.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status