juanmard/icestudio

View on GitHub
controllers/preferences.js

Summary

Maintainability
D
1 day
Test Coverage

File preferences.js has 334 lines of code (exceeds 250 allowed). Consider refactoring.
Open

// Please note that $uibModalInstance represents a modal window (instance) dependency.
// It is not the same as the $uibModal service.

/* eslint-disable camelcase */

Severity: Minor
Found in controllers/preferences.js - About 4 hrs to fix

    Function setExternalCollections has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          $scope.setExternalCollections = () => {
            var externalCollections = common.get('externalCollections');
            utils.renderForm(
              [
                {
    Severity: Minor
    Found in controllers/preferences.js - About 1 hr to fix

      Function setExternalPlugins has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            $scope.setExternalPlugins = () => {
              var externalPlugins = common.get('externalPlugins');
              utils.renderForm(
                [
                  {
      Severity: Minor
      Found in controllers/preferences.js - About 1 hr to fix

        Function setApioRepo has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              $scope.setApioRepo = () => {
                var apioRepo = common.get('apioRepo');
                var apioRef = common.get('apioRef');
                utils.renderForm(
                  [
        Severity: Minor
        Found in controllers/preferences.js - About 1 hr to fix

          Function setPythonEnv has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                $scope.setPythonEnv = function () {
                  let pythonEnv = common.get('pythonEnv');
                  let formSpecs = [
                    {
                      type: 'text',
          Severity: Minor
          Found in controllers/preferences.js - About 1 hr to fix

            Function showCollectionData has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                  $scope.showCollectionData = (collection) => {
                    const cname = collection.name;
                    $log.debug('[menu.showCollectionData] cname:', cname);
                    var readme = collection.content.readme;
                    $log.debug('[menu.showCollectionData] content:', collection.content);
            Severity: Minor
            Found in controllers/preferences.js - About 1 hr to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                    function _openWindow(url, title) {
                      $log.log(url);
                      return gui.Window.open(url, {
                        title: title,
                        focus: true,
              Severity: Major
              Found in controllers/preferences.js and 1 other location - About 2 hrs to fix
              controllers/menu.js on lines 827..840

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 80.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status