Sign upLogin

juanmard/icestudio

View on GitHub
Star
graphics/joint.command.js

Summary

Maintainability
F
3 days
Test Coverage

Function addCommand has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

  addCommand: function (cmdName, cell, graph, options) {
    'use strict';

    if (cmdName === 'change:labels' || cmdName === 'change:z') {
      return;
Severity: Minor
Found in graphics/joint.command.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File joint.command.js has 322 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
Copyright (c) 2016-2019 FPGAwars
Copyright (c) 2013 client IO
*/
Severity: Minor
Found in graphics/joint.command.js - About 3 hrs to fix

    Function addCommand has 85 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      addCommand: function (cmdName, cell, graph, options) {
    'use strict';

    if (cmdName === 'change:labels' || cmdName === 'change:z') {
      return;
    Severity: Major
    Found in graphics/joint.command.js - About 3 hrs to fix

      Function revertCommand has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
      Open

        revertCommand: function (command) {
    'use strict';
    this.stopListening();

    var batchCommand;
      Severity: Minor
      Found in graphics/joint.command.js - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function revertCommand has 53 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        revertCommand: function (command) {
    'use strict';
    this.stopListening();

    var batchCommand;
      Severity: Major
      Found in graphics/joint.command.js - About 2 hrs to fix

        Function applyCommand has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

          applyCommand: function (command) {
    'use strict';
    this.stopListening();

    var batchCommand;
        Severity: Minor
        Found in graphics/joint.command.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function applyCommand has 47 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          applyCommand: function (command) {
    'use strict';
    this.stopListening();

    var batchCommand;
        Severity: Minor
        Found in graphics/joint.command.js - About 1 hr to fix

          Function storeBatchCommand has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

            storeBatchCommand: function () {
    'use strict';
    // In order to store batch command it is necesary to run storeBatchCommand as many times as
    // initBatchCommand was executed
    if (this.batchCommand && this.batchLevel <= 0) {
          Severity: Minor
          Found in graphics/joint.command.js - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this function.
          Open

                return push(command);
          Severity: Major
          Found in graphics/joint.command.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                return push(command);
            Severity: Major
            Found in graphics/joint.command.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return push(command);
              Severity: Major
              Found in graphics/joint.command.js - About 30 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                          if (cell) {
            cell.set(attribute, data, options);
            var cellView = this.paper.findViewByModel(cell);
            if (cellView) {
              cellView.apply({undo: false, attribute: attribute});
                Severity: Major
                Found in graphics/joint.command.js and 1 other location - About 1 hr to fix
                graphics/joint.command.js on lines 278..284

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 68.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                          if (cell) {
            cell.set(attribute, data, options);
            var cellView = this.paper.findViewByModel(cell);
            if (cellView) {
              cellView.apply({undo: true, attribute: attribute});
                Severity: Major
                Found in graphics/joint.command.js and 1 other location - About 1 hr to fix
                graphics/joint.command.js on lines 339..345

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 68.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        case 'add':
          cmd.data.attributes.state = this.state;
          this.graph.addCell(cmd.data.attributes);
          break;
                Severity: Minor
                Found in graphics/joint.command.js and 1 other location - About 50 mins to fix
                graphics/joint.command.js on lines 246..249

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 51.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        case 'remove':
          cmd.data.attributes.state = this.state;
          this.graph.addCell(cmd.data.attributes);
          break;
                Severity: Minor
                Found in graphics/joint.command.js and 1 other location - About 50 mins to fix
                graphics/joint.command.js on lines 309..312

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 51.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status