juanmard/icestudio

View on GitHub
graphics/joint.routers.js

Summary

Maintainability
F
6 days
Test Coverage

Function ice has a Cognitive Complexity of 114 (exceeds 5 allowed). Consider refactoring.
Open

joint.routers.ice = (function (g, _, joint) {
  'use strict';

  var config = {
    // size of the step to find a route
Severity: Minor
Found in graphics/joint.routers.js - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function ice has 397 lines of code (exceeds 25 allowed). Consider refactoring.
Open

joint.routers.ice = (function (g, _, joint) {
  'use strict';

  var config = {
    // size of the step to find a route
Severity: Major
Found in graphics/joint.routers.js - About 1 day to fix

    File joint.routers.js has 400 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /* eslint-disable new-cap */
    
    joint.routers.ice = (function (g, _, joint) {
      'use strict';
    
    
    Severity: Minor
    Found in graphics/joint.routers.js - About 5 hrs to fix

      Function findRoute has 99 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        function findRoute(start, end, map, opt) {
          var step = opt.step;
          var startPoints, endPoints;
          var startCenter, endCenter;
      
      
      Severity: Major
      Found in graphics/joint.routers.js - About 3 hrs to fix

        Function build has 65 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          ObstacleMap.prototype.build = function (graph, link) {
            var opt = this.options;
        
            // source or target element could be excluded from set of obstacles
            var excludedEnds = _.chain(opt.excludeEnds)
        Severity: Major
        Found in graphics/joint.routers.js - About 2 hrs to fix

          Function router has 49 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            function router(vertices, opt) {
              resolveOptions(opt);
          
              /* jshint -W040 */
          
          
          Severity: Minor
          Found in graphics/joint.routers.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                if (end instanceof g.rect) {
                  endPoints = getRectPoints(end, opt.endDirections, opt);
                  endCenter = end.center().snapToGrid(step);
                } else {
                  endCenter = end.clone().snapToGrid(step);
            Severity: Major
            Found in graphics/joint.routers.js and 1 other location - About 2 hrs to fix
            graphics/joint.routers.js on lines 358..364

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 93.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                if (start instanceof g.rect) {
                  startPoints = getRectPoints(start, opt.startDirections, opt);
                  startCenter = start.center().snapToGrid(step);
                } else {
                  startCenter = start.clone().snapToGrid(step);
            Severity: Major
            Found in graphics/joint.routers.js and 1 other location - About 2 hrs to fix
            graphics/joint.routers.js on lines 367..373

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 93.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status