Sign upLogin

juanroldan1989/my-budget-app

View on GitHub
Star

Showing 3 of 5 total issues

Method call has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

  def call
    deals.each_with_index do |deal, index|
      # take the first deal, the third one, the fifth one...
      if index % 2 == 0
        first_deal  = deals[index]
Severity: Minor
Found in app/services/create_combined_deals.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method change has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def change
    create_table :deals do |t|
      t.string  :title
      t.string  :slug
      t.text    :description,   array: true, default: []
Severity: Minor
Found in db/migrate/20160314091617_create_deals.rb - About 1 hr to fix

    Method sanitize_price_text has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def sanitize_price_text
      with_text = page.css(".activityWrapper .activityText li")
        .to_a.collect { |item| item if item.text.present? }.compact

      if with_text.empty?
    Severity: Minor
    Found in app/services/book_me/scrap_site_deal.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language