junkurihara/cascade

View on GitHub
src/keys.js

Summary

Maintainability
C
7 hrs
Test Coverage

Function from has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
Open

  async from(format, {keys, suite, mode}){
    // assertion
    if((mode.indexOf('encrypt') >= 0 && mode.indexOf('verify') >= 0)
      || (mode.indexOf('encrypt') >= 0 && mode.indexOf('decrypt') >= 0)
      || (mode.indexOf('decrypt') >= 0 && mode.indexOf('sign') >= 0)
Severity: Minor
Found in src/keys.js - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Consider simplifying this complex logical expression.
Open

    if((mode.indexOf('encrypt') >= 0 && mode.indexOf('verify') >= 0)
      || (mode.indexOf('encrypt') >= 0 && mode.indexOf('decrypt') >= 0)
      || (mode.indexOf('decrypt') >= 0 && mode.indexOf('sign') >= 0)
      || (mode.indexOf('sign') >= 0 && mode.indexOf('verify') >= 0)
    ) throw new Error('InvalidMode');
Severity: Critical
Found in src/keys.js - About 1 hr to fix

    Function from has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      async from(format, {keys, suite, mode}){
        // assertion
        if((mode.indexOf('encrypt') >= 0 && mode.indexOf('verify') >= 0)
          || (mode.indexOf('encrypt') >= 0 && mode.indexOf('decrypt') >= 0)
          || (mode.indexOf('decrypt') >= 0 && mode.indexOf('sign') >= 0)
    Severity: Minor
    Found in src/keys.js - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status